[PR #873] feat: modal text input #1843

New issue

Open

opened 2026-03-14 15:36:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:36:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/873
Author: @juliamertz
Created: 11/15/2025
Status: 🔄 Open

Base: master ← Head: feat/modal-text-input

📝 Commits (1)

a5cb344 feat: modal text input

📊 Changes

10 files changed (+129 additions, -13 deletions)

View changed files

📝 spotify_player/src/config/mod.rs (+4 -0)
📝 spotify_player/src/event/mod.rs (+19 -2)
📝 spotify_player/src/event/page.rs (+19 -2)
📝 spotify_player/src/event/popup.rs (+37 -3)
📝 spotify_player/src/state/ui/mod.rs (+6 -1)
📝 spotify_player/src/state/ui/page.rs (+2 -1)
📝 spotify_player/src/state/ui/popup.rs (+17 -0)
📝 spotify_player/src/ui/page.rs (+1 -0)
📝 spotify_player/src/ui/popup.rs (+10 -2)
📝 spotify_player/src/ui/single_line_input.rs (+14 -2)

📄 Description

This PR adds the concept of a mode for search inputs (i'm not sure if this is the right abstraction)
This allows you to toggle between text input and and the results pane, this way all commands/action keymaps still work when you're focused on the results.

fixes #641

If this is something you'd like to include I can add some documentation

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/873 **Author:** [@juliamertz](https://github.com/juliamertz) **Created:** 11/15/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `feat/modal-text-input` --- ### 📝 Commits (1) - [`a5cb344`](https://github.com/aome510/spotify-player/commit/a5cb3447aa6fccb95dbb489ae3606d590143b9f2) feat: modal text input ### 📊 Changes **10 files changed** (+129 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/config/mod.rs` (+4 -0) 📝 `spotify_player/src/event/mod.rs` (+19 -2) 📝 `spotify_player/src/event/page.rs` (+19 -2) 📝 `spotify_player/src/event/popup.rs` (+37 -3) 📝 `spotify_player/src/state/ui/mod.rs` (+6 -1) 📝 `spotify_player/src/state/ui/page.rs` (+2 -1) 📝 `spotify_player/src/state/ui/popup.rs` (+17 -0) 📝 `spotify_player/src/ui/page.rs` (+1 -0) 📝 `spotify_player/src/ui/popup.rs` (+10 -2) 📝 `spotify_player/src/ui/single_line_input.rs` (+14 -2) </details> ### 📄 Description This PR adds the concept of a mode for search inputs (i'm not sure if this is the right abstraction) This allows you to toggle between text input and and the results pane, this way all commands/action keymaps still work when you're focused on the results. fixes #641 If this is something you'd like to include I can add some documentation --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>