[PR #849] [MERGED] Filter out keymaps with None command in shortcut help popup #1834

Closed
opened 2026-03-14 15:35:35 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/849
Author: @seanlinshiang
Created: 10/9/2025
Status: Merged
Merged: 12/22/2025
Merged by: @aome510

Base: masterHead: filter-none-keymap


📝 Commits (3)

  • e39469e filter out keymaps with None command in shortcut help popup
  • 25a8657 Merge branch 'master' into filter-none-keymap
  • 6b12a1f cargo fmt

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 spotify_player/src/ui/popup.rs (+4 -2)

📄 Description

This PR fixes an issue where the shortcut help popup displayed keymaps with Command::None.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/849 **Author:** [@seanlinshiang](https://github.com/seanlinshiang) **Created:** 10/9/2025 **Status:** ✅ Merged **Merged:** 12/22/2025 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `filter-none-keymap` --- ### 📝 Commits (3) - [`e39469e`](https://github.com/aome510/spotify-player/commit/e39469e167d38a7a7cee0bbc2bdf5a516c249ce3) filter out keymaps with None command in shortcut help popup - [`25a8657`](https://github.com/aome510/spotify-player/commit/25a8657947977fe93fa59ec6b01b3f497aea6ada) Merge branch 'master' into filter-none-keymap - [`6b12a1f`](https://github.com/aome510/spotify-player/commit/6b12a1f05edd5f9aa0d8fc0bf79fa0354c3c8cce) cargo fmt ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/ui/popup.rs` (+4 -2) </details> ### 📄 Description This PR fixes an issue where the shortcut help popup displayed keymaps with Command::None. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 15:35:35 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#1834
No description provided.