[PR #749] [MERGED] Add Support for RTL text in lyrics #1797

New issue

Closed

opened 2026-03-14 15:33:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:33:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/749
Author: @devceline
Created: 6/18/2025
Status: ✅ Merged
Merged: 6/22/2025
Merged by: @aome510

Base: master ← Head: master

📝 Commits (4)

f131818 feat: add support for rtl text
199d274 chore: clarify bidi_info comment
8e9705e chore: run fmt
b456427 lint

📊 Changes

3 files changed (+23 additions, -1 deletions)

View changed files

📝 Cargo.lock (+7 -0)
📝 spotify_player/Cargo.toml (+1 -0)
📝 spotify_player/src/state/model.rs (+15 -1)

📄 Description

Changes

Adds per-line RTL text detection and formatting.
Adds new dependency unicode-bidi

Note: Using unicode_bidi instead of just reversing the line also allows for properly formatting line with multi-lingual words.

Screenshot

Testing

Example Songs:

Desert Rose - Sting, Cheb Mami (https://open.spotify.com/track/3zYufmyv6HOuiHn1eMR6Ja?si=5623fc1c30e34131)
Forgive me - Saint Levant (https://open.spotify.com/track/6GZ1fXt4LMbYxqsh4KkzoU?si=d20d147d3c2a4fec)

Tested on:

Ghostty
Kitty
Alacritty

Resolves #750

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/749 **Author:** [@devceline](https://github.com/devceline) **Created:** 6/18/2025 **Status:** ✅ Merged **Merged:** 6/22/2025 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`f131818`](https://github.com/aome510/spotify-player/commit/f131818265fb618f16a0be204454c77d74b3e02b) feat: add support for rtl text - [`199d274`](https://github.com/aome510/spotify-player/commit/199d27468571398a336116ab3e03dee434971581) chore: clarify bidi_info comment - [`8e9705e`](https://github.com/aome510/spotify-player/commit/8e9705ee7e810b8a12fccb87d6edec00136ad29f) chore: run fmt - [`b456427`](https://github.com/aome510/spotify-player/commit/b456427ef5a5fd7fe930e7b035cc5599ae911c1e) lint ### 📊 Changes **3 files changed** (+23 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+7 -0) 📝 `spotify_player/Cargo.toml` (+1 -0) 📝 `spotify_player/src/state/model.rs` (+15 -1) </details> ### 📄 Description # Changes - Adds *per-line* RTL text detection and formatting. - Adds new dependency `unicode-bidi` Note: Using `unicode_bidi` instead of just reversing the line also allows for properly formatting line with multi-lingual words. # Screenshot ![image](https://github.com/user-attachments/assets/d17be04e-db1b-44a5-a988-aae9fa762c34) # Testing Example Songs: - Desert Rose - Sting, Cheb Mami (https://open.spotify.com/track/3zYufmyv6HOuiHn1eMR6Ja?si=5623fc1c30e34131) - Forgive me - Saint Levant (https://open.spotify.com/track/6GZ1fXt4LMbYxqsh4KkzoU?si=d20d147d3c2a4fec) Tested on: - Ghostty - Kitty - Alacritty Resolves #750 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>