[PR #733] [MERGED] feat: add currently playing lyric highlight #1792

New issue

Closed

opened 2026-03-14 15:33:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:33:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/733
Author: @JamesManningR
Created: 5/24/2025
Status: ✅ Merged
Merged: 6/22/2025
Merged by: @aome510

Base: master ← Head: master

📝 Commits (3)

4b82158 Added currently playing lyric highlight
b89b153 Made usage of ordering module consistent with other example in repo
ff8e400 Used a sensible order for switch statement

📊 Changes

3 files changed (+19 additions, -6 deletions)

View changed files

📝 docs/config.md (+2 -0)
📝 spotify_player/src/config/theme.rs (+13 -0)
📝 spotify_player/src/ui/page.rs (+4 -6)

📄 Description

I found it a little confusing the first time I opened the Lyrics panel and the currently playing lyric is dimmed.
I added a highlight for the current playing lyric

Should resolve confusion found in these issues

https://github.com/user-attachments/assets/0302d06b-7805-4938-ae6a-cad1c62d34b3

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/733 **Author:** [@JamesManningR](https://github.com/JamesManningR) **Created:** 5/24/2025 **Status:** ✅ Merged **Merged:** 6/22/2025 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`4b82158`](https://github.com/aome510/spotify-player/commit/4b8215891613952aeedd7e923351040495031cc6) Added currently playing lyric highlight - [`b89b153`](https://github.com/aome510/spotify-player/commit/b89b153db5d06527fcd2f4b482eab3e17bd12370) Made usage of ordering module consistent with other example in repo - [`ff8e400`](https://github.com/aome510/spotify-player/commit/ff8e40086031beb22e9bd5f05759ad056de6b14c) Used a sensible order for switch statement ### 📊 Changes **3 files changed** (+19 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `docs/config.md` (+2 -0) 📝 `spotify_player/src/config/theme.rs` (+13 -0) 📝 `spotify_player/src/ui/page.rs` (+4 -6) </details> ### 📄 Description I found it a little confusing the first time I opened the Lyrics panel and the currently playing lyric is dimmed. I added a highlight for the current playing lyric Should resolve confusion found in these issues - #721 - #713 - #692 <img width="778" alt="Screenshot 2025-05-24 at 20 15 46" src="https://github.com/user-attachments/assets/f0b93f14-ef3f-4a50-8370-59e8fc8e5079" /> https://github.com/user-attachments/assets/0302d06b-7805-4938-ae6a-cad1c62d34b3 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>