[PR #695] Play playlist 'CTRL+o' added #488 #1778

New issue

Open

opened 2026-03-14 15:32:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:32:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/695
Author: @ionescuaandrei
Created: 3/23/2025
Status: 🔄 Open

Base: master ← Head: feature/add-play#488

📝 Commits (4)

38ec4e9 Play playlist 'CTRL+o' added #488
9d26e9e Merge branch 'master' into feature/add-play#488
e8314db Play playlist 'CTRL+o' added (fixing the CI)#488
a58077b Merge branch 'feature/add-play#488' of https://github.com/ionescuaandrei/spotify-player into feature/add-play#488

📊 Changes

7 files changed (+116 additions, -7 deletions)

View changed files

📝 spotify_player/src/client/mod.rs (+1 -1)
📝 spotify_player/src/client/request.rs (+1 -0)
📝 spotify_player/src/command.rs (+7 -3)
📝 spotify_player/src/config/keymap.rs (+4 -0)
📝 spotify_player/src/event/mod.rs (+71 -0)
📝 spotify_player/src/event/page.rs (+19 -0)
📝 spotify_player/src/ui/page.rs (+13 -3)

📄 Description

This pull request introduces new playback functionalities and key bindings to the Spotify player, enhancing the user experience by allowing more control over playback actions. The most important changes include adding new commands and actions for playing selected playlists and contexts, as well as updating key bindings and UI elements to support these new features.

New Playback Functionalities:

Added PlayCurrentPlaylist to PlayerRequest enum in spotify_player/src/client/request.rs to handle playing the current playlist.
Implemented handling for PlayCurrentPlaylist in Client in spotify_player/src/client/mod.rs.

New Commands and Actions:

Added PlaySelectedPlaylist to Command enum and PlayContext to Action enum in spotify_player/src/command.rs. [1] [2]
Updated action constructors to include PlayContext for various entities like albums, artists, playlists, and shows in spotify_player/src/command.rs. [1] [2] [3] [4]

Key Bindings and Event Handling:

Added a key binding for Alt+P to play the current playlist in spotify_player/src/event/mod.rs.
Implemented handling for PlayContext action in different contexts (album, artist, playlist, show, episode) in spotify_player/src/event/mod.rs. [1] [2] [3] [4] [5] [6]

UI Updates:

Updated render_context_page function to include a "Play Context" button in the UI in spotify_player/src/ui/page.rs.
Added a default key binding for PlaySelectedPlaylist in KeymapConfig in spotify_player/src/config/keymap.rs.
[Copilot is generating a summary...]

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/695 **Author:** [@ionescuaandrei](https://github.com/ionescuaandrei) **Created:** 3/23/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `feature/add-play#488` --- ### 📝 Commits (4) - [`38ec4e9`](https://github.com/aome510/spotify-player/commit/38ec4e9c04ba2308646627cab332037c22af3501) Play playlist 'CTRL+o' added #488 - [`9d26e9e`](https://github.com/aome510/spotify-player/commit/9d26e9e8a16c47eff56b092482667e6ce8f1fc2f) Merge branch 'master' into feature/add-play#488 - [`e8314db`](https://github.com/aome510/spotify-player/commit/e8314dbcad80bf7e67e91b30fe55cfac9a9b3cb0) Play playlist 'CTRL+o' added (fixing the CI)#488 - [`a58077b`](https://github.com/aome510/spotify-player/commit/a58077b109e47d3740894e4278d90424ed998cd2) Merge branch 'feature/add-play#488' of https://github.com/ionescuaandrei/spotify-player into feature/add-play#488 ### 📊 Changes **7 files changed** (+116 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/client/mod.rs` (+1 -1) 📝 `spotify_player/src/client/request.rs` (+1 -0) 📝 `spotify_player/src/command.rs` (+7 -3) 📝 `spotify_player/src/config/keymap.rs` (+4 -0) 📝 `spotify_player/src/event/mod.rs` (+71 -0) 📝 `spotify_player/src/event/page.rs` (+19 -0) 📝 `spotify_player/src/ui/page.rs` (+13 -3) </details> ### 📄 Description This pull request introduces new playback functionalities and key bindings to the Spotify player, enhancing the user experience by allowing more control over playback actions. The most important changes include adding new commands and actions for playing selected playlists and contexts, as well as updating key bindings and UI elements to support these new features. ### New Playback Functionalities: * Added `PlayCurrentPlaylist` to `PlayerRequest` enum in `spotify_player/src/client/request.rs` to handle playing the current playlist. * Implemented handling for `PlayCurrentPlaylist` in `Client` in `spotify_player/src/client/mod.rs`. ### New Commands and Actions: * Added `PlaySelectedPlaylist` to `Command` enum and `PlayContext` to `Action` enum in `spotify_player/src/command.rs`. [[1]](diffhunk://#diff-aaa651a1b85c3377b86aecc56c92a0ceed8bc99d8c65025356684c2eea3b55edR83) [[2]](diffhunk://#diff-aaa651a1b85c3377b86aecc56c92a0ceed8bc99d8c65025356684c2eea3b55edR106) * Updated action constructors to include `PlayContext` for various entities like albums, artists, playlists, and shows in `spotify_player/src/command.rs`. [[1]](diffhunk://#diff-aaa651a1b85c3377b86aecc56c92a0ceed8bc99d8c65025356684c2eea3b55edR219) [[2]](diffhunk://#diff-aaa651a1b85c3377b86aecc56c92a0ceed8bc99d8c65025356684c2eea3b55edL233-R240) [[3]](diffhunk://#diff-aaa651a1b85c3377b86aecc56c92a0ceed8bc99d8c65025356684c2eea3b55edL250-R261) [[4]](diffhunk://#diff-aaa651a1b85c3377b86aecc56c92a0ceed8bc99d8c65025356684c2eea3b55edL267-R281) ### Key Bindings and Event Handling: * Added a key binding for `Alt+P` to play the current playlist in `spotify_player/src/event/mod.rs`. * Implemented handling for `PlayContext` action in different contexts (album, artist, playlist, show, episode) in `spotify_player/src/event/mod.rs`. [[1]](diffhunk://#diff-f440642b9f2e310f3369f009ab015f1bc6a06c64fba4a545372c67e0d55e4720R264-R271) [[2]](diffhunk://#diff-f440642b9f2e310f3369f009ab015f1bc6a06c64fba4a545372c67e0d55e4720R314-R322) [[3]](diffhunk://#diff-f440642b9f2e310f3369f009ab015f1bc6a06c64fba4a545372c67e0d55e4720R352-R360) [[4]](diffhunk://#diff-f440642b9f2e310f3369f009ab015f1bc6a06c64fba4a545372c67e0d55e4720R393-R401) [[5]](diffhunk://#diff-f440642b9f2e310f3369f009ab015f1bc6a06c64fba4a545372c67e0d55e4720R421-R429) [[6]](diffhunk://#diff-f440642b9f2e310f3369f009ab015f1bc6a06c64fba4a545372c67e0d55e4720R483-R498) ### UI Updates: * Updated `render_context_page` function to include a "Play Context" button in the UI in `spotify_player/src/ui/page.rs`. * Added a default key binding for `PlaySelectedPlaylist` in `KeymapConfig` in `spotify_player/src/config/keymap.rs`. [Copilot is generating a summary...] --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>