[PR #687] Fixed an issue where the player would get stuck on one song after playing for about an hour or so #1777

New issue

Open

opened 2026-03-14 15:32:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:32:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/687
Author: @alexjyong
Created: 3/4/2025
Status: 🔄 Open

Base: master ← Head: revamp-token-refreshing

📝 Commits (10+)

c90a758 Making this access_token_from_user_client_id refresh if needed
888a0d0 Update cd.yml
3683810 Update cd.yml
dc37c24 Update spotify.rs
0b901ad Update cd.yml
b91cff0 logging and token refresh
7fc5163 .
60771de Update token.rs
080e08b Update spotify.rs
f38e8ef Update spotify.rs

📊 Changes

1 file changed (+40 additions, -11 deletions)

View changed files

📝 spotify_player/src/client/spotify.rs (+40 -11)

📄 Description

Partially fixes https://github.com/aome510/spotify-player/issues/603

Looks like we weren't loading the new auth token into the Session when it got refreshed.

Unfortunately, this doesn't seem to be a complete fix, as I see the issue crop up sometimes, and the current page you are on the UI will have to be manually refreshed when the token expires (i.e. navigating to another page seems to help)

It does however, reduce the frequency when it happens. It seems to be the most stable when you get a long playlist running and let it be for a bit.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/687 **Author:** [@alexjyong](https://github.com/alexjyong) **Created:** 3/4/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `revamp-token-refreshing` --- ### 📝 Commits (10+) - [`c90a758`](https://github.com/aome510/spotify-player/commit/c90a758044fd89fd3ddfcf61c7a388e69df58635) Making this access_token_from_user_client_id refresh if needed - [`888a0d0`](https://github.com/aome510/spotify-player/commit/888a0d08bc23ebb2f430b170b0327529772713cc) Update cd.yml - [`3683810`](https://github.com/aome510/spotify-player/commit/3683810d715ff586f83dee755c88e882500c7d63) Update cd.yml - [`dc37c24`](https://github.com/aome510/spotify-player/commit/dc37c24a5870286259c9c6cd6211e14a8a5f569b) Update spotify.rs - [`0b901ad`](https://github.com/aome510/spotify-player/commit/0b901ad3d34abcb824530a3f693ec6328561e1d4) Update cd.yml - [`b91cff0`](https://github.com/aome510/spotify-player/commit/b91cff0b5b84bf0fe7ed2874323d4d589193e38c) logging and token refresh - [`7fc5163`](https://github.com/aome510/spotify-player/commit/7fc51635a696eeb5fe704ed3a9d06b0f3a4ab8e7) . - [`60771de`](https://github.com/aome510/spotify-player/commit/60771de41a84beedb8376d0eddfb7122437aef4c) Update token.rs - [`080e08b`](https://github.com/aome510/spotify-player/commit/080e08b96d38f355def9b8983f7447cb4218e5b1) Update spotify.rs - [`f38e8ef`](https://github.com/aome510/spotify-player/commit/f38e8ef65e685718789579a841ce40f632eb116a) Update spotify.rs ### 📊 Changes **1 file changed** (+40 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/client/spotify.rs` (+40 -11) </details> ### 📄 Description Partially fixes https://github.com/aome510/spotify-player/issues/603 Looks like we weren't loading the new auth token into the Session when it got refreshed. Unfortunately, this doesn't seem to be a complete fix, as I see the issue crop up _sometimes_, and the current page you are on the UI will have to be manually refreshed when the token expires (i.e. navigating to another page seems to help) It _does_ however, reduce the frequency when it happens. It seems to be the most stable when you get a long playlist running and let it be for a bit. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>