[PR #606] [MERGED] Refactoring #1749

Closed
opened 2026-03-14 15:30:59 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/606
Author: @bircni
Created: 11/18/2024
Status: Merged
Merged: 11/25/2024
Merged by: @aome510

Base: masterHead: patch01


📝 Commits (4)

📊 Changes

40 files changed (+573 additions, -467 deletions)

View changed files

📝 .github/workflows/ci.yml (+21 -0)
.typos.toml (+4 -0)
📝 Cargo.lock (+0 -22)
📝 Cargo.toml (+29 -0)
📝 lyric_finder/Cargo.toml (+3 -0)
📝 lyric_finder/src/lib.rs (+13 -12)
📝 spotify_player/Cargo.toml (+6 -1)
📝 spotify_player/src/auth.rs (+1 -1)
📝 spotify_player/src/cli/client.rs (+30 -27)
📝 spotify_player/src/cli/handlers.rs (+15 -14)
📝 spotify_player/src/cli/mod.rs (+1 -1)
📝 spotify_player/src/client/handlers.rs (+7 -5)
📝 spotify_player/src/client/mod.rs (+53 -38)
📝 spotify_player/src/client/request.rs (+1 -1)
📝 spotify_player/src/client/spotify.rs (+1 -0)
📝 spotify_player/src/command.rs (+1 -1)
📝 spotify_player/src/config/mod.rs (+15 -16)
📝 spotify_player/src/config/theme.rs (+2 -2)
📝 spotify_player/src/event/mod.rs (+23 -16)
📝 spotify_player/src/event/page.rs (+46 -50)

...and 20 more files

📄 Description

To improve code quality I enabled some lints, fixed them and improved the workflows


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/606 **Author:** [@bircni](https://github.com/bircni) **Created:** 11/18/2024 **Status:** ✅ Merged **Merged:** 11/25/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `patch01` --- ### 📝 Commits (4) - [`376b79a`](https://github.com/aome510/spotify-player/commit/376b79a0d3001e62ff3ff6c978d6e36243d1666c) enable lints - [`7ad6a16`](https://github.com/aome510/spotify-player/commit/7ad6a16c581febf631d68aebb8760f19a7e82b42) improve workflows - [`67eefe7`](https://github.com/aome510/spotify-player/commit/67eefe73b13ee9a8c28fa25e256f475908ad8993) fix workflow errors - [`a128feb`](https://github.com/aome510/spotify-player/commit/a128febddbd76f19d31789ea10c44a20cbd97372) Merge branch 'master' into patch01 ### 📊 Changes **40 files changed** (+573 additions, -467 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+21 -0) ➕ `.typos.toml` (+4 -0) 📝 `Cargo.lock` (+0 -22) 📝 `Cargo.toml` (+29 -0) 📝 `lyric_finder/Cargo.toml` (+3 -0) 📝 `lyric_finder/src/lib.rs` (+13 -12) 📝 `spotify_player/Cargo.toml` (+6 -1) 📝 `spotify_player/src/auth.rs` (+1 -1) 📝 `spotify_player/src/cli/client.rs` (+30 -27) 📝 `spotify_player/src/cli/handlers.rs` (+15 -14) 📝 `spotify_player/src/cli/mod.rs` (+1 -1) 📝 `spotify_player/src/client/handlers.rs` (+7 -5) 📝 `spotify_player/src/client/mod.rs` (+53 -38) 📝 `spotify_player/src/client/request.rs` (+1 -1) 📝 `spotify_player/src/client/spotify.rs` (+1 -0) 📝 `spotify_player/src/command.rs` (+1 -1) 📝 `spotify_player/src/config/mod.rs` (+15 -16) 📝 `spotify_player/src/config/theme.rs` (+2 -2) 📝 `spotify_player/src/event/mod.rs` (+23 -16) 📝 `spotify_player/src/event/page.rs` (+46 -50) _...and 20 more files_ </details> ### 📄 Description To improve code quality I enabled some lints, fixed them and improved the workflows --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 15:30:59 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#1749
No description provided.