[PR #613] [MERGED] Fix black image border #1748

Closed
opened 2026-03-14 15:30:59 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/613
Author: @mielpeeters
Created: 11/25/2024
Status: Merged
Merged: 11/30/2024
Merged by: @aome510

Base: masterHead: master


📝 Commits (2)

  • 7ed8f52 fix image border
  • bfb5716 Merge branch 'master' into mielpeeters/master

📊 Changes

1 file changed (+15 additions, -5 deletions)

View changed files

📝 spotify_player/src/ui/playback.rs (+15 -5)

📄 Description

Closes #612

  • clearing the image area now sets its background to the theme background color.
  • images are rendered with transparent: true as to not overwrite the background with black pixels when rendering album art with scale < 1.0

preview:
image
notice the lack of any black border around the album cover.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/613 **Author:** [@mielpeeters](https://github.com/mielpeeters) **Created:** 11/25/2024 **Status:** ✅ Merged **Merged:** 11/30/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`7ed8f52`](https://github.com/aome510/spotify-player/commit/7ed8f52596ad8fb05d1c44639d43a9ceefcbbe57) fix image border - [`bfb5716`](https://github.com/aome510/spotify-player/commit/bfb57161da71e17448b7f1e7d5ef63215cfc0a95) Merge branch 'master' into mielpeeters/master ### 📊 Changes **1 file changed** (+15 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/ui/playback.rs` (+15 -5) </details> ### 📄 Description Closes #612 - clearing the image area now sets its background to the theme background color. - images are rendered with `transparent: true` as to not overwrite the background with black pixels when rendering album art with `scale < 1.0` preview: ![image](https://github.com/user-attachments/assets/92b2dc78-e02c-432d-982b-c14c28dcfb01) notice the lack of any black border around the album cover. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 15:30:59 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#1748
No description provided.