[PR #604] add volume modification by mouse scrolling #1747

New issue

Open

opened 2026-03-14 15:30:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:30:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/604
Author: @VladWero08
Created: 11/10/2024
Status: 🔄 Open

Base: master ← Head: scroll-volume

📝 Commits (1)

d9cee5d add volume modification by mouse scrolling

📊 Changes

3 files changed (+60 additions, -19 deletions)

View changed files

📝 spotify_player/src/client/mod.rs (+14 -0)
📝 spotify_player/src/client/request.rs (+2 -0)
📝 spotify_player/src/event/mod.rs (+44 -19)

📄 Description

Resolves #446

In this PR we have added two more mouse event listeners, for scroll up and for scroll down of the mouse's wheel. This event listeners should only work if the keymap.toml has the following two entries:

[[keymaps]]
command = "VolumeUp"
key_sequence = "m s u"

[[keymaps]]
command = "VolumeDown"
key_sequence = "m s d"

where m s u stands for MouseScrollUp and m s d for MouseScrollDown.

Instead of mixing the key_sequence configuration with the mouse movements, we think that it would be useful to have a separate configuration for mouse events.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/604 **Author:** [@VladWero08](https://github.com/VladWero08) **Created:** 11/10/2024 **Status:** 🔄 Open **Base:** `master` ← **Head:** `scroll-volume` --- ### 📝 Commits (1) - [`d9cee5d`](https://github.com/aome510/spotify-player/commit/d9cee5dfabfec70050b044f17469eae6b0153360) add volume modification by mouse scrolling ### 📊 Changes **3 files changed** (+60 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/client/mod.rs` (+14 -0) 📝 `spotify_player/src/client/request.rs` (+2 -0) 📝 `spotify_player/src/event/mod.rs` (+44 -19) </details> ### 📄 Description Resolves [#446](https://github.com/aome510/spotify-player/issues/446) In this PR we have added two more mouse event listeners, for *scroll up* and for *scroll down* of the mouse's wheel. This event listeners should only work if the **keymap.toml** has the following two entries: ``` [[keymaps]] command = "VolumeUp" key_sequence = "m s u" [[keymaps]] command = "VolumeDown" key_sequence = "m s d" ``` where *m s u* stands for MouseScrollUp and *m s d* for MouseScrollDown. Instead of mixing the key_sequence configuration with the mouse movements, we think that it would be useful to have a separate configuration for mouse events. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>