[PR #552] [MERGED] implement podcast functionality #1734

Closed
opened 2026-03-14 15:30:11 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/552
Author: @SebRollen
Created: 8/22/2024
Status: Merged
Merged: 11/30/2024
Merged by: @aome510

Base: masterHead: episodes


📝 Commits (10+)

  • cee015e implement basic episode functionality
  • 5ac28ee implement AddToPlaylist
  • 1b3f96a implement shows
  • c0a00fa convert unwraps to expects
  • 8652680 impl GoToShow
  • fc98151 impl ShowActionsOnShow
  • 3ffeaf6 add release_date to episode
  • 396ebe9 combine playable queue actions
  • b696da3 combine playable playlist actions
  • e30d9fc revert some changes now that we have Debug + Clone

📊 Changes

23 files changed (+1104 additions, -340 deletions)

View changed files

📝 README.md (+1 -0)
📝 lyric_finder/src/lib.rs (+6 -5)
📝 spotify_player/src/cli/client.rs (+22 -21)
📝 spotify_player/src/client/handlers.rs (+27 -12)
📝 spotify_player/src/client/mod.rs (+186 -62)
📝 spotify_player/src/client/request.rs (+6 -3)
📝 spotify_player/src/command.rs (+41 -1)
📝 spotify_player/src/event/mod.rs (+137 -35)
📝 spotify_player/src/event/page.rs (+33 -0)
📝 spotify_player/src/event/popup.rs (+48 -5)
📝 spotify_player/src/event/window.rs (+97 -7)
📝 spotify_player/src/main.rs (+1 -0)
📝 spotify_player/src/media_control.rs (+46 -28)
📝 spotify_player/src/state/data.rs (+32 -9)
📝 spotify_player/src/state/model.rs (+103 -29)
📝 spotify_player/src/state/player.rs (+6 -9)
📝 spotify_player/src/state/ui/page.rs (+27 -15)
📝 spotify_player/src/state/ui/popup.rs (+18 -12)
📝 spotify_player/src/streaming.rs (+30 -19)
📝 spotify_player/src/ui/page.rs (+165 -40)

...and 3 more files

📄 Description

Work-in-progress implementation of podcasts. Still needs quite a bit of work, but this is a large change so I thought I'd open it up in draft mode in case anyone has any comments along the way.

Playback is working for podcast episodes, as is searching for specific episodes. But the playback is still not being populated—in the process of tracking down why that isn't happening now

Fixes #359
Fixes #457

Checklist (based on https://github.com/aome510/spotify-player/issues/457#issuecomment-2156052760)

  • Search
    • Shows (podcasts)
    • Episodes (podcast episodes)
  • Context menu
    • Shows
      • Copy link
      • Follow
    • Episodes
      • Go to show
      • Copy link
      • Add to playlist
      • Add to queue
  • Show detail page
  • Playback
    • Play audio
    • Show playback status

Screenshots

Search page
Screenshot 2024-08-22 at 10 14 06 PM

Show detail page
Screenshot 2024-08-22 at 11 05 13 PM


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/552 **Author:** [@SebRollen](https://github.com/SebRollen) **Created:** 8/22/2024 **Status:** ✅ Merged **Merged:** 11/30/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `episodes` --- ### 📝 Commits (10+) - [`cee015e`](https://github.com/aome510/spotify-player/commit/cee015e87a46d29f05dc4ab2ea7121156c3fec0e) implement basic episode functionality - [`5ac28ee`](https://github.com/aome510/spotify-player/commit/5ac28ee73032722b2b13a87ae5c55ae33daf7419) implement AddToPlaylist - [`1b3f96a`](https://github.com/aome510/spotify-player/commit/1b3f96ab942faac0a5ac0baf8ad6d4787a7012dd) implement shows - [`c0a00fa`](https://github.com/aome510/spotify-player/commit/c0a00fa7ed171a92b3155cdfe42176860d5244c3) convert unwraps to expects - [`8652680`](https://github.com/aome510/spotify-player/commit/865268009cf98989a850021002b4b4993393825b) impl GoToShow - [`fc98151`](https://github.com/aome510/spotify-player/commit/fc98151d1057c4dcaa7a6e0b8f2adeb80252438c) impl ShowActionsOnShow - [`3ffeaf6`](https://github.com/aome510/spotify-player/commit/3ffeaf6adce0175e9e441685799c71b8d183d5f8) add release_date to episode - [`396ebe9`](https://github.com/aome510/spotify-player/commit/396ebe93d7ed1694f8bdcdbf163fae63ecbc6356) combine playable queue actions - [`b696da3`](https://github.com/aome510/spotify-player/commit/b696da3507b1f073bdd99fd6fae4109bc626081b) combine playable playlist actions - [`e30d9fc`](https://github.com/aome510/spotify-player/commit/e30d9fc03627bb96c9257e7fe65dbbc02363ca50) revert some changes now that we have Debug + Clone ### 📊 Changes **23 files changed** (+1104 additions, -340 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -0) 📝 `lyric_finder/src/lib.rs` (+6 -5) 📝 `spotify_player/src/cli/client.rs` (+22 -21) 📝 `spotify_player/src/client/handlers.rs` (+27 -12) 📝 `spotify_player/src/client/mod.rs` (+186 -62) 📝 `spotify_player/src/client/request.rs` (+6 -3) 📝 `spotify_player/src/command.rs` (+41 -1) 📝 `spotify_player/src/event/mod.rs` (+137 -35) 📝 `spotify_player/src/event/page.rs` (+33 -0) 📝 `spotify_player/src/event/popup.rs` (+48 -5) 📝 `spotify_player/src/event/window.rs` (+97 -7) 📝 `spotify_player/src/main.rs` (+1 -0) 📝 `spotify_player/src/media_control.rs` (+46 -28) 📝 `spotify_player/src/state/data.rs` (+32 -9) 📝 `spotify_player/src/state/model.rs` (+103 -29) 📝 `spotify_player/src/state/player.rs` (+6 -9) 📝 `spotify_player/src/state/ui/page.rs` (+27 -15) 📝 `spotify_player/src/state/ui/popup.rs` (+18 -12) 📝 `spotify_player/src/streaming.rs` (+30 -19) 📝 `spotify_player/src/ui/page.rs` (+165 -40) _...and 3 more files_ </details> ### 📄 Description Work-in-progress implementation of podcasts. Still needs quite a bit of work, but this is a large change so I thought I'd open it up in draft mode in case anyone has any comments along the way. Playback is working for podcast episodes, as is searching for specific episodes. But the playback is still not being populated—in the process of tracking down why that isn't happening now Fixes #359 Fixes #457 Checklist (based on https://github.com/aome510/spotify-player/issues/457#issuecomment-2156052760) - [x] Search - [x] Shows (podcasts) - [x] Episodes (podcast episodes) - [x] Context menu - [x] Shows - [x] Copy link - [x] Follow - [x] Episodes - [x] Go to show - [x] Copy link - [x] Add to playlist - [x] Add to queue - [x] Show detail page - [x] Playback - [x] Play audio - [x] Show playback status ## Screenshots Search page <img width="1552" alt="Screenshot 2024-08-22 at 10 14 06 PM" src="https://github.com/user-attachments/assets/503932c8-bb6b-41ca-b218-db71ae8e12b6"> Show detail page <img width="1552" alt="Screenshot 2024-08-22 at 11 05 13 PM" src="https://github.com/user-attachments/assets/b64e9b04-979d-4581-bc60-fd5c40bac356"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 15:30:11 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#1734
No description provided.