[PR #553] [MERGED] fix copy command blocking #1733

New issue

Closed

opened 2026-03-14 15:30:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:30:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/553
Author: @juliamertz
Created: 8/22/2024
Status: ✅ Merged
Merged: 8/24/2024
Merged by: @aome510

Base: master ← Head: fix-copy-command

📝 Commits (1)

86b789f "fix" copy command blocking

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 spotify_player/src/event/clipboard.rs (+3 -3)

📄 Description

Fixes #538. It turns out that child.wait_with_output() blocks for a long time when either stdin or stderr is piped. I’ve tried multiple workarounds, but they all yield the same result.

This fix resolves the blocking issue, though we won't be able to read any output, making error messages completely useless.

Interestingly, when there is actually an error (e.g., passing invalid arguments), it doesn’t block and correctly reads from stderr.
I can share a small reproduction of this issue if that would be helpful.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/553 **Author:** [@juliamertz](https://github.com/juliamertz) **Created:** 8/22/2024 **Status:** ✅ Merged **Merged:** 8/24/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `fix-copy-command` --- ### 📝 Commits (1) - [`86b789f`](https://github.com/aome510/spotify-player/commit/86b789fc7e48a23020f8ad8f5dc7fb4854f9ec0f) "fix" copy command blocking ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/event/clipboard.rs` (+3 -3) </details> ### 📄 Description Fixes #538. It turns out that `child.wait_with_output()` blocks for a long time when either stdin or stderr is piped. I’ve tried multiple workarounds, but they all yield the same result. This fix resolves the blocking issue, though we won't be able to read any output, making error messages completely useless. Interestingly, when there is actually an error (e.g., passing invalid arguments), it doesn’t block and correctly reads from stderr. I can share a small reproduction of this issue if that would be helpful. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>