[PR #548] [MERGED] feat: client_id_cmd config option #1729

New issue

Closed

opened 2026-03-14 15:29:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:29:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/548
Author: @juliamertz
Created: 8/16/2024
Status: ✅ Merged
Merged: 8/17/2024
Merged by: @aome510

Base: master ← Head: private-client-id

📝 Commits (5)

d9054c1 feat: client_id_cmd config option
177ce01 use command struct for client_id_command option
e178ba5 Update spotify_player/src/streaming.rs
9cfc809 Apply suggestions from code review
6c3396b fix formatting and variable name

📊 Changes

5 files changed (+36 additions, -15 deletions)

View changed files

📝 docs/config.md (+1 -0)
📝 spotify_player/src/cli/handlers.rs (+2 -2)
📝 spotify_player/src/config/mod.rs (+30 -0)
📝 spotify_player/src/main.rs (+2 -1)
📝 spotify_player/src/streaming.rs (+1 -12)

📄 Description

This PR fixes #537 by adding a new config option client_id_cmd. When set, it will run this command and use its stdout as the client_id. I haven't been able to verify it's working on Windows, but that part has been copied from the rust docs so it should be fine.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/548 **Author:** [@juliamertz](https://github.com/juliamertz) **Created:** 8/16/2024 **Status:** ✅ Merged **Merged:** 8/17/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `private-client-id` --- ### 📝 Commits (5) - [`d9054c1`](https://github.com/aome510/spotify-player/commit/d9054c125cc8781931f6ac58cd672809311c8906) feat: client_id_cmd config option - [`177ce01`](https://github.com/aome510/spotify-player/commit/177ce013f531ef379c13100382b73170b797aeec) use command struct for client_id_command option - [`e178ba5`](https://github.com/aome510/spotify-player/commit/e178ba5285eeb849d5147f972a4c968ee4f6ee2c) Update spotify_player/src/streaming.rs - [`9cfc809`](https://github.com/aome510/spotify-player/commit/9cfc8096ea81f029a6eed2fb937cd7ae4cf88bf6) Apply suggestions from code review - [`6c3396b`](https://github.com/aome510/spotify-player/commit/6c3396be260f7822182581b245e45c741b62cde1) fix formatting and variable name ### 📊 Changes **5 files changed** (+36 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `docs/config.md` (+1 -0) 📝 `spotify_player/src/cli/handlers.rs` (+2 -2) 📝 `spotify_player/src/config/mod.rs` (+30 -0) 📝 `spotify_player/src/main.rs` (+2 -1) 📝 `spotify_player/src/streaming.rs` (+1 -12) </details> ### 📄 Description This PR fixes #537 by adding a new config option `client_id_cmd`. When set, it will run this command and use its stdout as the client_id. I haven't been able to verify it's working on Windows, but that part has been copied from the rust docs so it should be fine. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>