[PR #524] [MERGED] Does not return removed commands #1724

New issue

Closed

opened 2026-03-14 15:29:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:29:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/524
Author: @arouene
Created: 7/29/2024
Status: ✅ Merged
Merged: 7/29/2024
Merged by: @aome510

Base: master ← Head: removed-commands

📝 Commits (2)

3c967fc Does not return removed commands
fdb8539 merge with find condition

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 spotify_player/src/config/keymap.rs (+1 -1)

📄 Description

Commands set to None to remove the keybinding, where immediately returned by find_command_or_action_from_key_sequence on l.418.
Instead of looking for action keybinding.

Fix #523

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/524 **Author:** [@arouene](https://github.com/arouene) **Created:** 7/29/2024 **Status:** ✅ Merged **Merged:** 7/29/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `removed-commands` --- ### 📝 Commits (2) - [`3c967fc`](https://github.com/aome510/spotify-player/commit/3c967fcaf0beeff973d8f18ac7d802b4e8c3e96a) Does not return removed commands - [`fdb8539`](https://github.com/aome510/spotify-player/commit/fdb8539da6382fafe6676bb8b6e6182812b83d22) merge with find condition ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/config/keymap.rs` (+1 -1) </details> ### 📄 Description Commands set to None to remove the keybinding, where immediately returned by **find_command_or_action_from_key_sequence** on l.418. Instead of looking for action keybinding. Fix #523 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>