mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[PR #501] [MERGED] add jump to track command #1716
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#1716
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/aome510/spotify-player/pull/501
Author: @aNNiMON
Created: 7/10/2024
Status: ✅ Merged
Merged: 7/12/2024
Merged by: @aome510
Base:
master← Head:action-jumptotrack📝 Commits (2)
e9827d2add jump to track commandf11319eupdate command handling logic📊 Changes
6 files changed (+48 additions, -3 deletions)
View changed files
📝
README.md(+1 -0)📝
spotify_player/src/command.rs(+2 -0)📝
spotify_player/src/config/keymap.rs(+4 -0)📝
spotify_player/src/event/mod.rs(+27 -0)📝
spotify_player/src/event/window.rs(+2 -2)📝
spotify_player/src/state/data.rs(+12 -1)📄 Description
Resolves #484
I decided to refresh my ancient Rust knowledge and resolve my own feature request by myself 😄
It turns out that the simple jump to track action is better suited for this feature than the alternative of pressing
#and entering a track number. The latter requires a track position to be persistent in the model, while currently track numbers are calculated during rendering.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.