[PR #501] [MERGED] add jump to track command #1716

Closed
opened 2026-03-14 15:29:06 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/501
Author: @aNNiMON
Created: 7/10/2024
Status: Merged
Merged: 7/12/2024
Merged by: @aome510

Base: masterHead: action-jumptotrack


📝 Commits (2)

  • e9827d2 add jump to track command
  • f11319e update command handling logic

📊 Changes

6 files changed (+48 additions, -3 deletions)

View changed files

📝 README.md (+1 -0)
📝 spotify_player/src/command.rs (+2 -0)
📝 spotify_player/src/config/keymap.rs (+4 -0)
📝 spotify_player/src/event/mod.rs (+27 -0)
📝 spotify_player/src/event/window.rs (+2 -2)
📝 spotify_player/src/state/data.rs (+12 -1)

📄 Description

Resolves #484

I decided to refresh my ancient Rust knowledge and resolve my own feature request by myself 😄

It turns out that the simple jump to track action is better suited for this feature than the alternative of pressing # and entering a track number. The latter requires a track position to be persistent in the model, while currently track numbers are calculated during rendering.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/501 **Author:** [@aNNiMON](https://github.com/aNNiMON) **Created:** 7/10/2024 **Status:** ✅ Merged **Merged:** 7/12/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `action-jumptotrack` --- ### 📝 Commits (2) - [`e9827d2`](https://github.com/aome510/spotify-player/commit/e9827d2cdc5b968ecf986e4238e8fb7bf8f80f69) add jump to track command - [`f11319e`](https://github.com/aome510/spotify-player/commit/f11319e121ef36ac80ceb132b7672614f9943c9b) update command handling logic ### 📊 Changes **6 files changed** (+48 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -0) 📝 `spotify_player/src/command.rs` (+2 -0) 📝 `spotify_player/src/config/keymap.rs` (+4 -0) 📝 `spotify_player/src/event/mod.rs` (+27 -0) 📝 `spotify_player/src/event/window.rs` (+2 -2) 📝 `spotify_player/src/state/data.rs` (+12 -1) </details> ### 📄 Description Resolves #484 I decided to refresh my ancient Rust knowledge and resolve my own feature request by myself 😄 It turns out that the simple jump to track action is better suited for this feature than the alternative of pressing `#` and entering a track number. The latter requires a track position to be persistent in the model, while currently track numbers are calculated during rendering. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 15:29:06 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#1716
No description provided.