mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 17:35:50 +03:00
[PR #478] [MERGED] fix: decode html entities in playlist description #1708
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#1708
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/aome510/spotify-player/pull/478
Author: @juliamertz
Created: 6/27/2024
Status: ✅ Merged
Merged: 6/27/2024
Merged by: @aome510
Base:
master← Head:fix-decode-playlist-desc📝 Commits (1)
af55595fix: decode html entities in playlist description📊 Changes
3 files changed (+19 additions, -2 deletions)
View changed files
📝
Cargo.lock(+16 -0)📝
spotify_player/Cargo.toml(+1 -0)📝
spotify_player/src/state/model.rs(+2 -2)📄 Description
Noticed in one of my playlists the apostrophe in the description was displayed as
'. initially i tried to fix this without using a library, but it doesn't seem feasible to roll my own decoder for this. I've added the libraryhtml-escapewhich seems like the best out of a few choices.I'm not quite sure if we still need the regex to remove html tags as i haven't seen any examples of these being sent down.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.