[PR #474] [MERGED] fix #464 by adding full date to display next to albums #1703

New issue

Closed

opened 2026-03-14 15:28:33 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:28:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/474
Author: @DOD-101
Created: 6/25/2024
Status: ✅ Merged
Merged: 6/28/2024
Merged by: @aome510

Base: master ← Head: master

📝 Commits (3)

92a49da fix #464 by removing code to filter duplicates
ef66da9 Display full date next to Albums on Artist page
9668b11 Merge branch 'aome510:master' into master

📊 Changes

2 files changed (+3 additions, -11 deletions)

View changed files

📝 spotify_player/src/client/mod.rs (+2 -10)
📝 spotify_player/src/ui/page.rs (+1 -1)

📄 Description

fixes #464

This PR removes the code previously responsible for filtering out duplicate album names, which had caused #464.

I have decided to not any additional text to signal the difference between the albums with the same name as:

That might cause confusion as the the actual name of the album
There is in my opinion no problem with having 2 entries with the same name
The official Spotify client also handles this situation in this manner

This PR however doesn't entirely fix the bug described in the issue, as it seems that this is an upstream issue. The Spotify API doesn't return both copies of the album "Revelations" by "Audioslave" and accordingly the Spotify Client has the exact same behavior as spotfiy_player. But now the two versions of Original Fire show up as they should.

Spotify response sample:

jq '.items[].name' response.json

"Revelations"
"Out of Exile"
"Audioslave"
"Original Fire"
"Original Fire"
"Doesn't Remind Me"
"Sessions @AOL Music - EP (Live)"
"Your Time Has Come"
"Like A Stone (Live from New York City)"
"Be Yourself"
"Audioslave Live on Hollywood Blvd."
"Show Me How To Live"
"Cochise"
"Chris Cornell (Deluxe Edition)"
"Live 8 (Live, July 2005)"
"Rock Clássico"
"90s Grunge"
"Canciones De Hace Un Tiempo - Rock"
"20 Top Rock Hits"
"Summer Rocks Best Buy Version"
"Miami Ibiza St. Tropez, Selected Housetunes Vol. 1"

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/474 **Author:** [@DOD-101](https://github.com/DOD-101) **Created:** 6/25/2024 **Status:** ✅ Merged **Merged:** 6/28/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`92a49da`](https://github.com/aome510/spotify-player/commit/92a49da39365bae93daf0cb3f819b262d2ca2a7a) fix #464 by removing code to filter duplicates - [`ef66da9`](https://github.com/aome510/spotify-player/commit/ef66da9ce633e5a5ba9228099adf404c88de669a) Display full date next to Albums on Artist page - [`9668b11`](https://github.com/aome510/spotify-player/commit/9668b1171267ba0adedbb151f2983d2f3a7172da) Merge branch 'aome510:master' into master ### 📊 Changes **2 files changed** (+3 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/client/mod.rs` (+2 -10) 📝 `spotify_player/src/ui/page.rs` (+1 -1) </details> ### 📄 Description fixes #464 This PR removes the code previously responsible for filtering out duplicate album names, which had caused #464. I have decided to not any additional text to signal the difference between the albums with the same name as: 1) That might cause confusion as the the actual name of the album 2) There is in my opinion no problem with having 2 entries with the same name 3) The official Spotify client also handles this situation in this manner This PR however doesn't entirely fix the bug described in the issue, as it seems that this is an upstream issue. The Spotify API doesn't return both copies of the album "Revelations" by "Audioslave" and accordingly the Spotify Client has the exact same behavior as spotfiy_player. But now the two versions of Original Fire show up as they should. [Spotify response sample](https://developer.spotify.com/documentation/web-api/reference/get-an-artists-albums): `jq '.items[].name' response.json` ``` "Revelations" "Out of Exile" "Audioslave" "Original Fire" "Original Fire" "Doesn't Remind Me" "Sessions @AOL Music - EP (Live)" "Your Time Has Come" "Like A Stone (Live from New York City)" "Be Yourself" "Audioslave Live on Hollywood Blvd." "Show Me How To Live" "Cochise" "Chris Cornell (Deluxe Edition)" "Live 8 (Live, July 2005)" "Rock Clássico" "90s Grunge" "Canciones De Hace Un Tiempo - Rock" "20 Top Rock Hits" "Summer Rocks Best Buy Version" "Miami Ibiza St. Tropez, Selected Housetunes Vol. 1" ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>