[PR #460] [MERGED] Added support for image cache downloading without image Feature #1702

New issue

Closed

opened 2026-03-14 15:28:33 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:28:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/460
Author: @jStimpert0430
Created: 6/1/2024
Status: ✅ Merged
Merged: 6/2/2024
Merged by: @aome510

Base: master ← Head: master

📝 Commits (5)

7069a33 Added support for image cache downloading without image Feature -> Uses enable_cover_image_cache app.toml option instead
8c6a049 Added suggested changes, reverted MemoryCache Feature Checks
db23682 Reverted Cargo.toml
1036d7c cleanup
640b646 fix clippy

📊 Changes

1 file changed (+15 additions, -20 deletions)

View changed files

📝 spotify_player/src/client/mod.rs (+15 -20)

📄 Description

Resolves #458

Image cache download is now solely based upon the enable_cover_image_cache option regardless if the image feature is used or not.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/460 **Author:** [@jStimpert0430](https://github.com/jStimpert0430) **Created:** 6/1/2024 **Status:** ✅ Merged **Merged:** 6/2/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`7069a33`](https://github.com/aome510/spotify-player/commit/7069a33c9fdc855741a71d2b2d9ca9b167f396d9) Added support for image cache downloading without image Feature -> Uses enable_cover_image_cache app.toml option instead - [`8c6a049`](https://github.com/aome510/spotify-player/commit/8c6a049851824d9446e30f2681dabd172b970d8b) Added suggested changes, reverted MemoryCache Feature Checks - [`db23682`](https://github.com/aome510/spotify-player/commit/db23682ce588cd49088c59905a666533900065b8) Reverted Cargo.toml - [`1036d7c`](https://github.com/aome510/spotify-player/commit/1036d7c8eb33af0b103dbc1183789a9b1aa1a38d) cleanup - [`640b646`](https://github.com/aome510/spotify-player/commit/640b646327c25f706377d0a7a25ba8057f11c7eb) fix clippy ### 📊 Changes **1 file changed** (+15 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/client/mod.rs` (+15 -20) </details> ### 📄 Description Resolves #458 Image cache download is now solely based upon the `enable_cover_image_cache` option regardless if the `image` feature is used or not. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>