[PR #429] [MERGED] Add album to queue action #1693

Closed
opened 2026-03-14 15:28:01 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/429
Author: @nikosavola
Created: 4/24/2024
Status: Merged
Merged: 4/26/2024
Merged by: @aome510

Base: masterHead: 407-add-album-to-queue


📝 Commits (3)

  • c22967b Add album to queue action
  • 2de1559 Try supporting keymapping Z to add Album to queue
  • 4fa0d2f fix build

📊 Changes

6 files changed (+26 additions, -2 deletions)

View changed files

📝 spotify_player/src/client/mod.rs (+10 -0)
📝 spotify_player/src/client/request.rs (+1 -0)
📝 spotify_player/src/command.rs (+2 -0)
📝 spotify_player/src/event/page.rs (+4 -2)
📝 spotify_player/src/event/popup.rs (+4 -0)
📝 spotify_player/src/event/window.rs (+5 -0)

📄 Description

Hi @aome510,

I'm new to Rust bu tried implementing the Add album to queue action but could not get the development version working locally. I'm left with a blank screen when running the binary even from master after cargo build. Do you need to do something else or is the master failing? I have a release version authenticated with spotify and working.

Are there any additional places we need to add AddAlbumToQueue, AddToQueue and the AddSelectedItemToQueue for supporting keymapped queue.

Drafted until ready.

Closes #407


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/429 **Author:** [@nikosavola](https://github.com/nikosavola) **Created:** 4/24/2024 **Status:** ✅ Merged **Merged:** 4/26/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `407-add-album-to-queue` --- ### 📝 Commits (3) - [`c22967b`](https://github.com/aome510/spotify-player/commit/c22967b2a5a10b2b2c2316cb5849cd8f6d837ab3) Add album to queue action - [`2de1559`](https://github.com/aome510/spotify-player/commit/2de1559a2a7c22dee89c5864da29c8644af78837) Try supporting keymapping Z to add Album to queue - [`4fa0d2f`](https://github.com/aome510/spotify-player/commit/4fa0d2f3006f39229f5b4ba90dae1de05d1ef4cc) fix build ### 📊 Changes **6 files changed** (+26 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/client/mod.rs` (+10 -0) 📝 `spotify_player/src/client/request.rs` (+1 -0) 📝 `spotify_player/src/command.rs` (+2 -0) 📝 `spotify_player/src/event/page.rs` (+4 -2) 📝 `spotify_player/src/event/popup.rs` (+4 -0) 📝 `spotify_player/src/event/window.rs` (+5 -0) </details> ### 📄 Description Hi @aome510, I'm new to Rust bu tried implementing the _Add album to queue_ action but could not get the development version working locally. I'm left with a blank screen when running the binary even from master after `cargo build`. Do you need to do something else or is the master failing? I have a release version authenticated with spotify and working. Are there any additional places we need to add `AddAlbumToQueue`, `AddToQueue` and the `AddSelectedItemToQueue` for supporting keymapped queue. Drafted until ready. Closes #407 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 15:28:01 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#1693
No description provided.