[PR #420] [MERGED] Miscellaneous UI improvements #1692

New issue

Closed

opened 2026-03-14 15:28:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:28:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/420
Author: @aome510
Created: 4/21/2024
Status: ✅ Merged
Merged: 4/21/2024
Merged by: @aome510

Base: master ← Head: misc-ui-improvements

📝 Commits (10+)

3a45044 rename UIState::create_*_page to UIState::*_page
360ce26 re-use navigation command handler for scrolling
a2ec042 support searching in command help page
9fc2a0a update tips for commands README
adf6684 support more StyleModifier
f521049 remove redundant default component_style construction
2b186df support rendering playlist's description
8dd1709 cargo fmt
9d22b0a implement handle_navigation_command as function instead of macro
e6f6ba1 minor tweaks

📊 Changes

14 files changed (+239 additions, -184 deletions)

View changed files

📝 README.md (+6 -5)
📝 docs/config.md (+11 -1)
📝 examples/theme.toml (+1 -13)
📝 scripts/theme_parse (+0 -12)
📝 spotify_player/src/config/keymap.rs (+12 -0)
📝 spotify_player/src/config/theme.rs (+21 -0)
📝 spotify_player/src/event/mod.rs (+13 -13)
📝 spotify_player/src/event/page.rs (+71 -86)
📝 spotify_player/src/event/popup.rs (+7 -7)
📝 spotify_player/src/event/window.rs (+22 -12)
📝 spotify_player/src/state/model.rs (+9 -0)
📝 spotify_player/src/state/ui/mod.rs (+28 -16)
📝 spotify_player/src/state/ui/page.rs (+9 -2)
📝 spotify_player/src/ui/page.rs (+29 -17)

📄 Description

Changes

support searching inside the command help page
renders playlist's description inside context page if exists
add a new playlist_desc style component
support more style modifiers based on https://docs.rs/ratatui/latest/ratatui/style/struct.Modifier.html
re-use handle_navigation_command to handle scrolling commands

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/420 **Author:** [@aome510](https://github.com/aome510) **Created:** 4/21/2024 **Status:** ✅ Merged **Merged:** 4/21/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `misc-ui-improvements` --- ### 📝 Commits (10+) - [`3a45044`](https://github.com/aome510/spotify-player/commit/3a4504484d02a8951d0402b2d72c837ab112d4a6) rename `UIState::create_*_page` to `UIState::*_page` - [`360ce26`](https://github.com/aome510/spotify-player/commit/360ce2614e4ec4b344790d7d5a9a8db3e9a816fd) re-use navigation command handler for scrolling - [`a2ec042`](https://github.com/aome510/spotify-player/commit/a2ec0425057b6a38afa3ac80e3773f417a4ed5e5) support searching in command help page - [`9fc2a0a`](https://github.com/aome510/spotify-player/commit/9fc2a0a9e71537fc2f6faee4de93cff244fff39d) update tips for commands README - [`adf6684`](https://github.com/aome510/spotify-player/commit/adf66843ea76c0dfe8d667407e4afb94471ca02f) support more `StyleModifier` - [`f521049`](https://github.com/aome510/spotify-player/commit/f5210499611c803a536557a4214ad2d241653634) remove redundant default `component_style` construction - [`2b186df`](https://github.com/aome510/spotify-player/commit/2b186df41e23cce0bfb4d90a5eab576984e98477) support rendering playlist's description - [`8dd1709`](https://github.com/aome510/spotify-player/commit/8dd1709610c1116ef896af10eae0e2144abd3de7) cargo fmt - [`9d22b0a`](https://github.com/aome510/spotify-player/commit/9d22b0a21afd84ececbfb1fa53716bc81b34fe72) implement handle_navigation_command as function instead of macro - [`e6f6ba1`](https://github.com/aome510/spotify-player/commit/e6f6ba1ccd56a1c3d3027903f1464bb084e715d5) minor tweaks ### 📊 Changes **14 files changed** (+239 additions, -184 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+6 -5) 📝 `docs/config.md` (+11 -1) 📝 `examples/theme.toml` (+1 -13) 📝 `scripts/theme_parse` (+0 -12) 📝 `spotify_player/src/config/keymap.rs` (+12 -0) 📝 `spotify_player/src/config/theme.rs` (+21 -0) 📝 `spotify_player/src/event/mod.rs` (+13 -13) 📝 `spotify_player/src/event/page.rs` (+71 -86) 📝 `spotify_player/src/event/popup.rs` (+7 -7) 📝 `spotify_player/src/event/window.rs` (+22 -12) 📝 `spotify_player/src/state/model.rs` (+9 -0) 📝 `spotify_player/src/state/ui/mod.rs` (+28 -16) 📝 `spotify_player/src/state/ui/page.rs` (+9 -2) 📝 `spotify_player/src/ui/page.rs` (+29 -17) </details> ### 📄 Description ## Changes - support searching inside the command help page - renders playlist's description inside context page if exists - add a new `playlist_desc` style component - support more style modifiers based on https://docs.rs/ratatui/latest/ratatui/style/struct.Modifier.html - re-use `handle_navigation_command` to handle scrolling commands --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>