[PR #390] [MERGED] re-render image if the last rectangle is different from the current one #1686

New issue

Closed

opened 2026-03-14 15:27:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:27:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/390
Author: @aome510
Created: 3/6/2024
Status: ✅ Merged
Merged: 3/12/2024
Merged by: @aome510

Base: master ← Head: fix-image-rendering-bottom

📝 Commits (5)

e9d8074 re-render image if the last rectangle is different from the current one
acfc0b0 clear the image rectangle before rendering
0b8da21 set skip only when image is not rendered
4f28c2e separate clearing phase and rendering phase for cover image
f792250 update rendering order to render playback window first

📊 Changes

3 files changed (+60 additions, -34 deletions)

View changed files

📝 spotify_player/src/state/ui/mod.rs (+12 -4)
📝 spotify_player/src/ui/mod.rs (+9 -5)
📝 spotify_player/src/ui/playback.rs (+39 -25)

📄 Description

Resolves #389

This PR also reverts the rendering order back to the before v0.17.0 in which playback window is rendered before any popups.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/390 **Author:** [@aome510](https://github.com/aome510) **Created:** 3/6/2024 **Status:** ✅ Merged **Merged:** 3/12/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `fix-image-rendering-bottom` --- ### 📝 Commits (5) - [`e9d8074`](https://github.com/aome510/spotify-player/commit/e9d8074ebf5a19e264a80f0e09b96694e47a98ca) re-render image if the last rectangle is different from the current one - [`acfc0b0`](https://github.com/aome510/spotify-player/commit/acfc0b09bbb401d13ca5b68c0d86b5467001e43b) clear the image rectangle before rendering - [`0b8da21`](https://github.com/aome510/spotify-player/commit/0b8da217386cdd6e0ee58eaba240c087f786a062) set skip only when image is not rendered - [`4f28c2e`](https://github.com/aome510/spotify-player/commit/4f28c2e54056cc1f8ac0185f2d6802386a391359) separate clearing phase and rendering phase for cover image - [`f792250`](https://github.com/aome510/spotify-player/commit/f7922504e6937070d575b8752f70069b1e9f1b81) update rendering order to render playback window first ### 📊 Changes **3 files changed** (+60 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/state/ui/mod.rs` (+12 -4) 📝 `spotify_player/src/ui/mod.rs` (+9 -5) 📝 `spotify_player/src/ui/playback.rs` (+39 -25) </details> ### 📄 Description Resolves #389 This PR also reverts the rendering order back to the before `v0.17.0` in which playback window is rendered before any popups. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>