[PR #400] [MERGED] ensure no popup is rendered on top the playback window #1684

Closed
opened 2026-03-14 15:27:28 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/400
Author: @aome510
Created: 3/23/2024
Status: Merged
Merged: 3/23/2024
Merged by: @aome510

Base: masterHead: fix-render-issue-with-image


📝 Commits (2)

  • 2b30e53 ensure no popup is rendered on top the playback window
  • 36c8534 remove ubuntu-beta CI

📊 Changes

3 files changed (+9 additions, -19 deletions)

View changed files

📝 .github/workflows/ci.yml (+0 -4)
📝 spotify_player/src/ui/mod.rs (+5 -3)
📝 spotify_player/src/ui/popup.rs (+4 -12)

📄 Description

Resolves #399.

Fix rendering issue with image feature when a popup is rendered on top of the cover image. This PR updates the UI logic to ensure that the whole playback window is always visible from the UI.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/400 **Author:** [@aome510](https://github.com/aome510) **Created:** 3/23/2024 **Status:** ✅ Merged **Merged:** 3/23/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `fix-render-issue-with-image` --- ### 📝 Commits (2) - [`2b30e53`](https://github.com/aome510/spotify-player/commit/2b30e536d6603aee4ba4b9bbd42e4ec2d7dfb153) ensure no popup is rendered on top the playback window - [`36c8534`](https://github.com/aome510/spotify-player/commit/36c8534516f3898ae067202199c475034706ed3c) remove `ubuntu-beta` CI ### 📊 Changes **3 files changed** (+9 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+0 -4) 📝 `spotify_player/src/ui/mod.rs` (+5 -3) 📝 `spotify_player/src/ui/popup.rs` (+4 -12) </details> ### 📄 Description Resolves #399. Fix rendering issue with `image` feature when a popup is rendered on top of the cover image. This PR updates the UI logic to ensure that the whole playback window is always visible from the UI. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 15:27:28 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#1684
No description provided.