[PR #346] [MERGED] Wait for the copy command to exit. #1665

New issue

Closed

opened 2026-03-14 15:26:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:26:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/346
Author: @Fuyukai
Created: 1/24/2024
Status: ✅ Merged
Merged: 1/24/2024
Merged by: @aome510

Base: master ← Head: fix-zombies

📝 Commits (2)

ec9653f Wait for the copy command to exit.
8949e29 Run cargo format.

📊 Changes

1 file changed (+7 additions, -5 deletions)

View changed files

📝 spotify_player/src/event/popup.rs (+7 -5)

📄 Description

There's a bit of jank in the error handling to make sure it waits for the child to exit on all possible paths, and it suppresses the stdin error if .wait() fails, but I couldn't think of a nicer way. Very open to fixing this.

Closes #345.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/346 **Author:** [@Fuyukai](https://github.com/Fuyukai) **Created:** 1/24/2024 **Status:** ✅ Merged **Merged:** 1/24/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `fix-zombies` --- ### 📝 Commits (2) - [`ec9653f`](https://github.com/aome510/spotify-player/commit/ec9653fec47ba9f8728af68f51963ca0dd61e160) Wait for the copy command to exit. - [`8949e29`](https://github.com/aome510/spotify-player/commit/8949e292f3ea4d47ff911338aff35ebefed3a3b5) Run cargo format. ### 📊 Changes **1 file changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/event/popup.rs` (+7 -5) </details> ### 📄 Description There's a bit of jank in the error handling to make sure it waits for the child to exit on all possible paths, and it suppresses the stdin error if ``.wait()`` fails, but I couldn't think of a nicer way. Very open to fixing this. Closes #345. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>