[PR #343] [MERGED] build: use `cross` for cross-compilation, locally and in CD #1660

New issue

Closed

opened 2026-03-14 15:25:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:25:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/343
Author: @LucasFA
Created: 1/23/2024
Status: ✅ Merged
Merged: 1/25/2024
Merged by: @aome510

Base: master ← Head: cross-compile

📝 Commits (2)

b6bb4db build: local cross compilation
e73e938 build(cd): use cross for CD

📊 Changes

3 files changed (+27 additions, -23 deletions)

View changed files

📝 .github/workflows/cd.yml (+7 -23)
➕ Cross.toml (+12 -0)
➕ ci/Dockerfile-cross (+8 -0)

📄 Description

TL;DR: of each commit is in order:

Enables local cross compilation from Linux (at least x86_64) to Linux both aarch64 or armv7 by using cross.
Leverages cross and applies it to the CD workflow to build the release binaries.

Major significant benefit it actually just using current images - the FROM in the Dockerfile resolves to ghcr.io/cross-rs/aarch64-unknown-linux-gnu:latest. That by itself could have been a PR.

By the way, to see that TLDR in the code I recommend checking each commit individually. Both together it just looks like a mess 🙃

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/343 **Author:** [@LucasFA](https://github.com/LucasFA) **Created:** 1/23/2024 **Status:** ✅ Merged **Merged:** 1/25/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `cross-compile` --- ### 📝 Commits (2) - [`b6bb4db`](https://github.com/aome510/spotify-player/commit/b6bb4db20bd637a7218f616e4986f38d1b691480) build: local cross compilation - [`e73e938`](https://github.com/aome510/spotify-player/commit/e73e9383ca5f70368473179719f3040113184a36) build(cd): use cross for CD ### 📊 Changes **3 files changed** (+27 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/cd.yml` (+7 -23) ➕ `Cross.toml` (+12 -0) ➕ `ci/Dockerfile-cross` (+8 -0) </details> ### 📄 Description TL;DR: of each commit is in order: 1. Enables local cross compilation from Linux (at least x86_64) to Linux both aarch64 or armv7 by using `cross`. 2. Leverages cross and applies it to the CD workflow to build the release binaries. Major significant benefit it actually just using current images - the FROM in the Dockerfile resolves to `ghcr.io/cross-rs/aarch64-unknown-linux-gnu:latest`. That by itself could have been a PR. By the way, to see that TLDR in the code I recommend checking each commit individually. Both together it just looks like a mess 🙃 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>