[PR #317] [MERGED] Improve theme configurations #1654

Closed
opened 2026-03-14 15:25:42 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/317
Author: @aome510
Created: 12/9/2023
Status: Merged
Merged: 12/9/2023
Merged by: @aome510

Base: masterHead: improve-theme-configs


📝 Commits (4)

  • 3c4590f update example theme config file
  • f0c3ff9 update Color's convert and deserialize logic
  • 86395f1 support using hex string to configure component_style background/foreground
  • 70f2257 cleanup

📊 Changes

3 files changed (+116 additions, -131 deletions)

View changed files

📝 docs/config.md (+14 -8)
📝 examples/theme.toml (+35 -74)
📝 spotify_player/src/config/theme.rs (+67 -49)

📄 Description

Changes

  • update parsing logic for theme::Color and theme::StyleColor
  • update example theme config file
  • improve theme documentation

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/317 **Author:** [@aome510](https://github.com/aome510) **Created:** 12/9/2023 **Status:** ✅ Merged **Merged:** 12/9/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `improve-theme-configs` --- ### 📝 Commits (4) - [`3c4590f`](https://github.com/aome510/spotify-player/commit/3c4590f884c27b98d4f1493558813d7dc57586e4) update example theme config file - [`f0c3ff9`](https://github.com/aome510/spotify-player/commit/f0c3ff9a76fc755bdb4b4894048658e09b768bea) update `Color`'s convert and deserialize logic - [`86395f1`](https://github.com/aome510/spotify-player/commit/86395f1b798a6d773537a0d4e1db92b5795b8e77) support using hex string to configure `component_style` background/foreground - [`70f2257`](https://github.com/aome510/spotify-player/commit/70f22573fb2a2ca15c09d555c2aab117c3f2556e) cleanup ### 📊 Changes **3 files changed** (+116 additions, -131 deletions) <details> <summary>View changed files</summary> 📝 `docs/config.md` (+14 -8) 📝 `examples/theme.toml` (+35 -74) 📝 `spotify_player/src/config/theme.rs` (+67 -49) </details> ### 📄 Description ## Changes - update parsing logic for `theme::Color` and `theme::StyleColor` - update example theme config file - improve theme documentation --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 15:25:42 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#1654
No description provided.