[PR #298] [MERGED] Allow disabling notify when client is not streaming #1646

New issue

Closed

opened 2026-03-14 15:25:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:25:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/298
Author: @VenMolom
Created: 11/25/2023
Status: ✅ Merged
Merged: 11/28/2023
Merged by: @aome510

Base: master ← Head: notify-streaming-only

📝 Commits (1)

1903d22 Allow disabling notify when client is not streaming

📊 Changes

4 files changed (+17 additions, -2 deletions)

View changed files

📝 docs/config.md (+2 -1)
📝 examples/app.toml (+1 -0)
📝 spotify_player/src/client/mod.rs (+9 -1)
📝 spotify_player/src/config/mod.rs (+5 -0)

📄 Description

Added notify_streaming_only config option. When true, client only sends notification if it has streaming connection.

Coupled with enable_streaming set to DaemonOnly, this prevents duplicate notifications from being sent when both daemon and UI to control it are running.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/298 **Author:** [@VenMolom](https://github.com/VenMolom) **Created:** 11/25/2023 **Status:** ✅ Merged **Merged:** 11/28/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `notify-streaming-only` --- ### 📝 Commits (1) - [`1903d22`](https://github.com/aome510/spotify-player/commit/1903d22344a16adc1663fa73b5beb0f221e6e64f) Allow disabling notify when client is not streaming ### 📊 Changes **4 files changed** (+17 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `docs/config.md` (+2 -1) 📝 `examples/app.toml` (+1 -0) 📝 `spotify_player/src/client/mod.rs` (+9 -1) 📝 `spotify_player/src/config/mod.rs` (+5 -0) </details> ### 📄 Description Added `notify_streaming_only` config option. When true, client only sends notification if it has streaming connection. Coupled with `enable_streaming` set to `DaemonOnly`, this prevents duplicate notifications from being sent when both daemon and UI to control it are running. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>