[PR #275] [MERGED] Allow shuffling context playback from CLI #1635

New issue

Closed

opened 2026-03-14 15:24:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:24:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/275
Author: @rudiejd
Created: 10/22/2023
Status: ✅ Merged
Merged: 10/23/2023
Merged by: @aome510

Base: master ← Head: shuffle-playlists-cli

📝 Commits (4)

94d2ae1 feat: allow shuffling context playback from CLI
127ce23 respond to feedback
4b6271a finish responding to feedback, run cargo fmt
4948ba7 Update spotify_player/src/client/mod.rs

📊 Changes

7 files changed (+45 additions, -12 deletions)

View changed files

📝 spotify_player/src/cli/client.rs (+10 -6)
📝 spotify_player/src/cli/commands.rs (+7 -0)
📝 spotify_player/src/cli/handlers.rs (+7 -1)
📝 spotify_player/src/cli/mod.rs (+13 -3)
📝 spotify_player/src/client/mod.rs (+4 -1)
📝 spotify_player/src/event/mod.rs (+1 -1)
📝 spotify_player/src/event/window.rs (+3 -0)

📄 Description

Closes https://github.com/aome510/spotify-player/issues/239

I did this by adding an option that would change the playback context to shuffle. The other option that immediately occurred to me was to shuffle all tracks in the playback locally in the same way that StartLikedTracks, but that shifts computation to the client and doesn't achieve the desired result IMO

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/275 **Author:** [@rudiejd](https://github.com/rudiejd) **Created:** 10/22/2023 **Status:** ✅ Merged **Merged:** 10/23/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `shuffle-playlists-cli` --- ### 📝 Commits (4) - [`94d2ae1`](https://github.com/aome510/spotify-player/commit/94d2ae1b437b31f6d33965a85c8ad0a345a40205) feat: allow shuffling context playback from CLI - [`127ce23`](https://github.com/aome510/spotify-player/commit/127ce230e644b8662e31853220a57d59d60e7b36) respond to feedback - [`4b6271a`](https://github.com/aome510/spotify-player/commit/4b6271abbaef6a79500ebbeab958504409700751) finish responding to feedback, run cargo fmt - [`4948ba7`](https://github.com/aome510/spotify-player/commit/4948ba70cf5fce1baaecc90795fbf7cd0a23496b) Update spotify_player/src/client/mod.rs ### 📊 Changes **7 files changed** (+45 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/cli/client.rs` (+10 -6) 📝 `spotify_player/src/cli/commands.rs` (+7 -0) 📝 `spotify_player/src/cli/handlers.rs` (+7 -1) 📝 `spotify_player/src/cli/mod.rs` (+13 -3) 📝 `spotify_player/src/client/mod.rs` (+4 -1) 📝 `spotify_player/src/event/mod.rs` (+1 -1) 📝 `spotify_player/src/event/window.rs` (+3 -0) </details> ### 📄 Description Closes https://github.com/aome510/spotify-player/issues/239 I did this by adding an option that would change the playback context to shuffle. The other option that immediately occurred to me was to shuffle all tracks in the playback locally in the same way that `StartLikedTracks`, but that shifts computation to the client and doesn't achieve the desired result IMO --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>