mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[PR #252] [MERGED] Set PulseAudio app properties using environment variables #1623
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#1623
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/aome510/spotify-player/pull/252
Author: @Schnouki
Created: 9/13/2023
Status: ✅ Merged
Merged: 9/15/2023
Merged by: @aome510
Base:
master← Head:pulseaudio-env-variables📝 Commits (2)
8693f2dSet PulseAudio app properties using environment variables34335f0Include device name in PulseAudio stream description📊 Changes
1 file changed (+26 additions, -0 deletions)
View changed files
📝
spotify_player/src/main.rs(+26 -0)📄 Description
This allows other PulseAudio clients (like mixers etc.) to show more details about the audio stream.
For example, using the standard PulseAudio volume control (
pavucontrol):It would even be possible to do things like add the current track's title and artist in env variables, but I don't think anyone actually makes use of this, so it seems rather pointless to me. Instead, I decided to focus on the most useful ones.
Librespot only sets those when used as a standalone binary, but not as a library:
github.com/librespot-org/librespot@054074c920/src/main.rs (L1211-L1246)Documentation about this PulseAudio feature: https://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/Developer/Clients/ApplicationProperties/
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.