[PR #242] [MERGED] Make it possible to enable streaming only in daemon mode #1621

Closed
opened 2026-03-14 15:23:49 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/242
Author: @Schnouki
Created: 8/31/2023
Status: Merged
Merged: 9/2/2023
Merged by: @aome510

Base: masterHead: streaming-daemon-only


📝 Commits (2)

  • 226c2fd Make it possible to enable streaming only in daemon mode
  • 41bf9b7 Ensure boolean values are still accepted for enable_streaming

📊 Changes

4 files changed (+45 additions, -6 deletions)

View changed files

📝 docs/config.md (+3 -2)
📝 examples/app.toml (+1 -1)
📝 spotify_player/src/config/mod.rs (+38 -2)
📝 spotify_player/src/main.rs (+3 -1)

📄 Description

Make enable_streaming an enum with a DaemonOnly option. To keep backward compatibility, true and false are still accepted too.

Fixes #238.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/242 **Author:** [@Schnouki](https://github.com/Schnouki) **Created:** 8/31/2023 **Status:** ✅ Merged **Merged:** 9/2/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `streaming-daemon-only` --- ### 📝 Commits (2) - [`226c2fd`](https://github.com/aome510/spotify-player/commit/226c2fda553feb8c804991740e1f893c385e188c) Make it possible to enable streaming only in daemon mode - [`41bf9b7`](https://github.com/aome510/spotify-player/commit/41bf9b7fcf042aff3339dbf5e44895c6892611d5) Ensure boolean values are still accepted for enable_streaming ### 📊 Changes **4 files changed** (+45 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `docs/config.md` (+3 -2) 📝 `examples/app.toml` (+1 -1) 📝 `spotify_player/src/config/mod.rs` (+38 -2) 📝 `spotify_player/src/main.rs` (+3 -1) </details> ### 📄 Description Make `enable_streaming` an enum with a `DaemonOnly` option. To keep backward compatibility, `true` and `false` are still accepted too. Fixes #238. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 15:23:49 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#1621
No description provided.