[PR #234] [CLOSED] Implement UI for creating new playlists #1619

New issue

Closed

opened 2026-03-14 15:23:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:23:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/234
Author: @nuugen
Created: 8/13/2023
Status: ❌ Closed

Base: master ← Head: create-playlist-ui

📝 Commits (1)

77c08d0 Implement UI for creating new playlists

📊 Changes

9 files changed (+252 additions, -37 deletions)

View changed files

📝 spotify_player/src/cli/client.rs (+14 -31)
📝 spotify_player/src/client/mod.rs (+49 -0)
📝 spotify_player/src/command.rs (+4 -0)
📝 spotify_player/src/config/keymap.rs (+4 -0)
📝 spotify_player/src/event/mod.rs (+6 -0)
📝 spotify_player/src/event/popup.rs (+103 -1)
📝 spotify_player/src/event/window.rs (+7 -0)
📝 spotify_player/src/state/ui/popup.rs (+28 -5)
📝 spotify_player/src/ui/popup.rs (+37 -0)

📄 Description

This attempts to implement a rudimentary UI flow for creating a new playlist.

Resolves #87.

Usage:
While focused on the playlist window, pressing N will show a pop-up prompting user to enter the name and the description of the new playlist to be created. Pressing Tab here will switch focus between the two fields.

Limitation:
For simplicity, the public and collab statuses will be omitted. The desc field looks to be broken upstream in rspotify - the new playlist does not seem to have this informatino attached. Both of these limitations are also observed in the CLI implementation (#222). This seems to be a misobservation.

I'm also relatively new to Rust, so I mainly focused on submitting a purely functioning implementation, without much regard to the DRYness of code - once there are more instances of the pop-up with input prompt (similar to both Search and PlaylistCreate here), it should be abstracted.

Suggestions and critics are of course more than welcome and would help me a lot getting started in my Rust journey.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/234 **Author:** [@nuugen](https://github.com/nuugen) **Created:** 8/13/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `create-playlist-ui` --- ### 📝 Commits (1) - [`77c08d0`](https://github.com/aome510/spotify-player/commit/77c08d0c68794abf0bd1a92b0d0581fc4a27ffff) Implement UI for creating new playlists ### 📊 Changes **9 files changed** (+252 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/cli/client.rs` (+14 -31) 📝 `spotify_player/src/client/mod.rs` (+49 -0) 📝 `spotify_player/src/command.rs` (+4 -0) 📝 `spotify_player/src/config/keymap.rs` (+4 -0) 📝 `spotify_player/src/event/mod.rs` (+6 -0) 📝 `spotify_player/src/event/popup.rs` (+103 -1) 📝 `spotify_player/src/event/window.rs` (+7 -0) 📝 `spotify_player/src/state/ui/popup.rs` (+28 -5) 📝 `spotify_player/src/ui/popup.rs` (+37 -0) </details> ### 📄 Description This attempts to implement a rudimentary UI flow for creating a new playlist. Resolves #87. **Usage:** While focused on the playlist window, pressing `N` will show a pop-up prompting user to enter the name and the description of the new playlist to be created. Pressing `Tab` here will switch focus between the two fields. **Limitation:** For simplicity, the `public` and `collab` statuses will be omitted. ~The `desc` field looks to be broken upstream in `rspotify` - the new playlist does not seem to have this informatino attached. Both of these limitations are also observed in the CLI implementation (#222).~ This seems to be a misobservation. I'm also relatively new to Rust, so I mainly focused on submitting a purely functioning implementation, without much regard to the DRYness of code - once there are more instances of the pop-up with input prompt (similar to both `Search` and `PlaylistCreate` here), it should be abstracted. Suggestions and critics are of course more than welcome and would help me a lot getting started in my Rust journey. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>