[GH-ISSUE #302] Configuration option to disable notifications #161

New issue

Closed

opened 2026-03-02 23:45:06 +03:00 by kerem · 3 comments

kerem commented

2026-03-02 23:45:06 +03:00

Owner

Originally created by @oleksandr-oksenenko on GitHub (Nov 28, 2023).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/302

Is your feature request related to a problem? Please describe.
No way to disable notifications in the configuration.

Describe the solution you'd like
Would be great to have a configuration option that would allow to disable all notifications from spotify_player.

Describe alternatives you've considered
Manually installing using cargo without notify feature is an alternative, however, it's not very convenient.

Additional context
spotify_player notifications on MacOS are a bit ugly (using Finder icon). Also, I try to limit to a minimum the amount of the notifications I get.

Originally created by @oleksandr-oksenenko on GitHub (Nov 28, 2023). Original GitHub issue: https://github.com/aome510/spotify-player/issues/302 **Is your feature request related to a problem? Please describe.** No way to disable notifications in the configuration. **Describe the solution you'd like** Would be great to have a configuration option that would allow to disable all notifications from spotify_player. **Describe alternatives you've considered** Manually installing using cargo without `notify` feature is an alternative, however, it's not very convenient. **Additional context** spotify_player notifications on MacOS are a bit ugly (using Finder icon). Also, I try to limit to a minimum the amount of the notifications I get.

kerem

2026-03-02 23:45:06 +03:00

closed this issue
added the
enhancement
label

kerem commented

2026-03-02 23:45:07 +03:00

Author

Owner

@aome510 commented on GitHub (Nov 28, 2023):

Related: https://github.com/aome510/spotify-player/issues/292. This issue seems to be specific to the brew package manager as it installs the application with notify feature when the feature is disabled by default.

@aome510 commented on GitHub (Nov 28, 2023): Related: https://github.com/aome510/spotify-player/issues/292. This issue seems to be specific to the brew package manager as it installs the application with `notify` feature when the feature is disabled by default.

kerem commented

2026-03-02 23:45:07 +03:00

Author

Owner

@oleksandr-oksenenko commented on GitHub (Nov 28, 2023):

@aome510 thanks for reply!
is it disabled by default specifically because it has some issues?
Generally, I feel like hiding features behind compilation flags instead of configurations is a bit inconvenient, since you either have to rely on defaults provided by the packager or resort to compiling the project yourself. Is there a specific reason for this?

@oleksandr-oksenenko commented on GitHub (Nov 28, 2023): @aome510 thanks for reply! is it disabled by default specifically because it has some issues? Generally, I feel like hiding features behind compilation flags instead of configurations is a bit inconvenient, since you either have to rely on defaults provided by the packager or resort to compiling the project yourself. Is there a specific reason for this?

kerem commented

2026-03-02 23:45:07 +03:00

Author

Owner

@aome510 commented on GitHub (Nov 28, 2023):

@aome510 thanks for reply! is it disabled by default specifically because it has some issues? Generally, I feel like hiding features behind compilation flags instead of configurations is a bit inconvenient, since you either have to rely on defaults provided by the packager or resort to compiling the project yourself. Is there a specific reason for this?

The main reason is to avoid redundant dependencies when building the application if people don't need the notification feature, not because it has some issues. This "feature-behind-compilation-flag" pattern is quite common in rust ecosystem (and possibly c++). That said, I agree that it's inconvenient to hide features behind compilation flags instead of configurations.

@aome510 commented on GitHub (Nov 28, 2023): > @aome510 thanks for reply! is it disabled by default specifically because it has some issues? Generally, I feel like hiding features behind compilation flags instead of configurations is a bit inconvenient, since you either have to rely on defaults provided by the packager or resort to compiling the project yourself. Is there a specific reason for this? The main reason is to avoid redundant dependencies when building the application if people don't need the notification feature, not because it has some issues. This "feature-behind-compilation-flag" pattern is quite common in rust ecosystem (and possibly c++). That said, I agree that it's inconvenient to hide features behind compilation flags instead of configurations.

kerem referenced this issue

2026-03-02 23:49:12 +03:00

[PR #162] [MERGED] Use spotify_player instead of spotify-player in documents #646

kerem referenced this issue

2026-03-14 13:00:57 +03:00

[GH-ISSUE #161] Consistently document that command is spotify_player, not spotify-player #1015

kerem referenced this issue

2026-03-14 15:21:54 +03:00

[PR #162] [MERGED] Use spotify_player instead of spotify-player in documents #1582