[PR #223] [MERGED] Allow removing a keybind #1608

Closed
opened 2026-03-14 15:23:16 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/223
Author: @Kuba314
Created: 7/26/2023
Status: Merged
Merged: 7/29/2023
Merged by: @aome510

Base: masterHead: allow-keybind-removal


📝 Commits (1)

📊 Changes

4 files changed (+29 additions, -12 deletions)

View changed files

📝 docs/config.md (+4 -1)
📝 spotify_player/src/command.rs (+3 -0)
📝 spotify_player/src/config/keymap.rs (+6 -0)
📝 spotify_player/src/ui/popup.rs (+16 -11)

📄 Description

This is done by introducing a new Command::None, which does nothing and also doesn't appear in the help menu.

To remove a default or any previously defined keybind, simply set its command like this:

[[keymaps]]
command = "None"
key_sequence = "q"

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/223 **Author:** [@Kuba314](https://github.com/Kuba314) **Created:** 7/26/2023 **Status:** ✅ Merged **Merged:** 7/29/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `allow-keybind-removal` --- ### 📝 Commits (1) - [`bb336df`](https://github.com/aome510/spotify-player/commit/bb336df9a60cfade4478c6df3dcff9cf5e3ec190) Allow removing a keybind ### 📊 Changes **4 files changed** (+29 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `docs/config.md` (+4 -1) 📝 `spotify_player/src/command.rs` (+3 -0) 📝 `spotify_player/src/config/keymap.rs` (+6 -0) 📝 `spotify_player/src/ui/popup.rs` (+16 -11) </details> ### 📄 Description This is done by introducing a new `Command::None`, which does nothing and also doesn't appear in the help menu. To remove a default or any previously defined keybind, simply set its command like this: ```toml [[keymaps]] command = "None" key_sequence = "q" ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 15:23:16 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#1608
No description provided.