[PR #172] [MERGED] Add `enable_image_cache` config option #1589

New issue

Closed

opened 2026-03-14 15:22:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:22:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/172
Author: @aome510
Created: 3/28/2023
Status: ✅ Merged
Merged: 3/28/2023
Merged by: @aome510

Base: master ← Head: add-enable-image-cache-config

📝 Commits (3)

645a46e add enable_cover_image_cache config option
9d89b35 refactor cover image retrieval code to handle new config option
5446c76 fix clippy errors

📊 Changes

4 files changed (+62 additions, -57 deletions)

View changed files

📝 docs/config.md (+2 -1)
📝 examples/app.toml (+1 -0)
📝 spotify_player/src/client/mod.rs (+55 -56)
📝 spotify_player/src/config/mod.rs (+4 -0)

📄 Description

Resolves #154

Allows to disable/enable storing cover images inside the $APP_CACHE/image folder using enable_image_cache config option.

Note: this new config option is ignored if notify feature is enabled as the feature requires reading the cover images from the cache folder to display a notification on Linux.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/172 **Author:** [@aome510](https://github.com/aome510) **Created:** 3/28/2023 **Status:** ✅ Merged **Merged:** 3/28/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `add-enable-image-cache-config` --- ### 📝 Commits (3) - [`645a46e`](https://github.com/aome510/spotify-player/commit/645a46ef0111c62e9879166e15156bfe15528393) add `enable_cover_image_cache` config option - [`9d89b35`](https://github.com/aome510/spotify-player/commit/9d89b35bf246f33a1172f0d0d05287402bbc6777) refactor cover image retrieval code to handle new config option - [`5446c76`](https://github.com/aome510/spotify-player/commit/5446c7682e345ab07f4f56fdc3aceacdfddddf9e) fix clippy errors ### 📊 Changes **4 files changed** (+62 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `docs/config.md` (+2 -1) 📝 `examples/app.toml` (+1 -0) 📝 `spotify_player/src/client/mod.rs` (+55 -56) 📝 `spotify_player/src/config/mod.rs` (+4 -0) </details> ### 📄 Description Resolves #154 Allows to disable/enable storing cover images inside the `$APP_CACHE/image` folder using `enable_image_cache` config option. **Note**: this new config option is ignored if `notify` feature is enabled as the feature requires reading the cover images from the cache folder to display a notification on Linux. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>