[PR #137] [MERGED] Implement notification support #1581

New issue

Closed

opened 2026-03-14 15:21:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:21:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/137
Author: @aome510
Created: 2/17/2023
Status: ✅ Merged
Merged: 2/18/2023
Merged by: @aome510

Base: master ← Head: add-notify-feature

📝 Commits (9)

beb8ddb add notify-rust as dep and notify feature
6278e3a implement a simple notify engine on playback change
2cd6bad move notify and fetch image codes into update_current_playback_state function
af8dead save downloaded track cover images in cache folder
3cb05bd add icon to notification and avoid sending same noti multiple times
02d1db8 use dbus for notify_rust
469aa2a cleanup
6c29cf6 Merge remote-tracking branch 'origin/master' into add-notify-feature
ed9fcfe update README

📊 Changes

9 files changed (+257 additions, -66 deletions)

View changed files

📝 .dir-locals.el (+1 -1)
📝 .github/workflows/ci.yml (+1 -1)
📝 Cargo.lock (+118 -7)
📝 README.md (+16 -4)
📝 spotify_player/Cargo.toml (+2 -0)
📝 spotify_player/src/client/mod.rs (+106 -41)
📝 spotify_player/src/main.rs (+9 -2)
📝 spotify_player/src/state/mod.rs (+4 -0)
📝 spotify_player/src/state/player.rs (+0 -10)

📄 Description

Resolves #123

Changes

added notify feature (with notify_rust as dependencies) for desktop notification support
saved downloaded cover images into $APP_CACHE_FOLDER/image

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/137 **Author:** [@aome510](https://github.com/aome510) **Created:** 2/17/2023 **Status:** ✅ Merged **Merged:** 2/18/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `add-notify-feature` --- ### 📝 Commits (9) - [`beb8ddb`](https://github.com/aome510/spotify-player/commit/beb8ddb39284a62c83701e05bca64ef88dff736c) add `notify-rust` as dep and `notify` feature - [`6278e3a`](https://github.com/aome510/spotify-player/commit/6278e3a59a9f1961a601322975246c83f4234aa5) implement a simple notify engine on playback change - [`2cd6bad`](https://github.com/aome510/spotify-player/commit/2cd6badcbf501299aa628d39683a745eb0b5a060) move notify and fetch image codes into `update_current_playback_state` function - [`af8dead`](https://github.com/aome510/spotify-player/commit/af8deadf667f99a83f4cbf6e40e1e2167563e7dc) save downloaded track cover images in cache folder - [`3cb05bd`](https://github.com/aome510/spotify-player/commit/3cb05bda095172d9188ea8636ee24e83acd47527) add `icon` to notification and avoid sending same noti multiple times - [`02d1db8`](https://github.com/aome510/spotify-player/commit/02d1db869fc1fdf9c7e6a269f1008473b3cb36d9) use `dbus` for `notify_rust` - [`469aa2a`](https://github.com/aome510/spotify-player/commit/469aa2a4dc39480fbd7f9b2b65aeeacea8a2735b) cleanup - [`6c29cf6`](https://github.com/aome510/spotify-player/commit/6c29cf60b588579f6f098719571a756e54955ee0) Merge remote-tracking branch 'origin/master' into add-notify-feature - [`ed9fcfe`](https://github.com/aome510/spotify-player/commit/ed9fcfe222cd036f9d0a4526942a10403d9b4325) update README ### 📊 Changes **9 files changed** (+257 additions, -66 deletions) <details> <summary>View changed files</summary> 📝 `.dir-locals.el` (+1 -1) 📝 `.github/workflows/ci.yml` (+1 -1) 📝 `Cargo.lock` (+118 -7) 📝 `README.md` (+16 -4) 📝 `spotify_player/Cargo.toml` (+2 -0) 📝 `spotify_player/src/client/mod.rs` (+106 -41) 📝 `spotify_player/src/main.rs` (+9 -2) 📝 `spotify_player/src/state/mod.rs` (+4 -0) 📝 `spotify_player/src/state/player.rs` (+0 -10) </details> ### 📄 Description Resolves #123 ## Changes - added `notify` feature (with `notify_rust` as dependencies) for desktop notification support - saved downloaded cover images into `$APP_CACHE_FOLDER/image` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>