[PR #131] [MERGED] Added more navigation commands #1572

New issue

Closed

opened 2026-03-14 15:21:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:21:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/131
Author: @aome510
Created: 2/13/2023
Status: ✅ Merged
Merged: 2/14/2023
Merged by: @aome510

Base: master ← Head: more-navigation-commands

📝 Commits (10+)

ad06e1e add page_size_in_rows config option
a4de9c7 add PageSelectNextOrScrollDown and PageSelectPreviousOrScrollUp commands
5ddb7b5 add .dir-locals
cbad883 bound the lyric page's scroll offset to the lyric paragraph's number of rows
2c548af introduce handle_navigation_commands_for_page macro to avoid code duplication
49c1f22 add handlers for page navigation commands
51ada3f handle page navigation commands for command help popup and lyric page
6638196 Merge remote-tracking branch 'origin/master' into more-navigation-commands
7c45706 cleanup
18bdc7d ignore clippy warning for handle_command_for_track_table_window

📊 Changes

12 files changed (+257 additions, -146 deletions)

View changed files

➕ .dir-locals.el (+4 -0)
📝 README.md (+51 -47)
📝 docs/config.md (+1 -0)
📝 examples/app.toml (+1 -0)
📝 spotify_player/src/command.rs (+17 -0)
📝 spotify_player/src/config/keymap.rs (+32 -0)
📝 spotify_player/src/config/mod.rs (+4 -0)
📝 spotify_player/src/event/mod.rs (+0 -1)
📝 spotify_player/src/event/page.rs (+64 -14)
📝 spotify_player/src/event/popup.rs (+20 -2)
📝 spotify_player/src/event/window.rs (+24 -50)
📝 spotify_player/src/ui/page.rs (+39 -32)

📄 Description

Resolves #127

Changes

added more navigation commands
- PageSelectNextOrScrollDown
- PageSelectPreviousOrScrollUp
- SelectFirstOrScrollToTop
- SelectLastOrScrollToBottom
added page_size_in_rows config option to control the behavior of page navigation commands
added macro handle_navigation_commands_for_page to reduce the code duplication when implementing handlers for navigation commands

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/131 **Author:** [@aome510](https://github.com/aome510) **Created:** 2/13/2023 **Status:** ✅ Merged **Merged:** 2/14/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `more-navigation-commands` --- ### 📝 Commits (10+) - [`ad06e1e`](https://github.com/aome510/spotify-player/commit/ad06e1ec096ca32b4757b87b6080852304f17a00) add `page_size_in_rows` config option - [`a4de9c7`](https://github.com/aome510/spotify-player/commit/a4de9c7d01cfac2377be8826458f10eb2b509eb3) add `PageSelectNextOrScrollDown` and `PageSelectPreviousOrScrollUp` commands - [`5ddb7b5`](https://github.com/aome510/spotify-player/commit/5ddb7b56c8870cf171d86d8160a5949718fee0d5) add `.dir-locals` - [`cbad883`](https://github.com/aome510/spotify-player/commit/cbad8839d27c892e429b8aa11b548b541ab48a78) bound the lyric page's scroll offset to the lyric paragraph's number of rows - [`2c548af`](https://github.com/aome510/spotify-player/commit/2c548af99a347123f4e8976be936962081abb0f4) introduce `handle_navigation_commands_for_page` macro to avoid code duplication - [`49c1f22`](https://github.com/aome510/spotify-player/commit/49c1f224e791c62a801b7e2c8255fc63c881712b) add handlers for page navigation commands - [`51ada3f`](https://github.com/aome510/spotify-player/commit/51ada3f82567a6011280c4ea4d90f37fd0d56d39) handle page navigation commands for command help popup and lyric page - [`6638196`](https://github.com/aome510/spotify-player/commit/663819693999210c7b2ac15cf3160574f8ed4694) Merge remote-tracking branch 'origin/master' into more-navigation-commands - [`7c45706`](https://github.com/aome510/spotify-player/commit/7c45706e73c180ad6f4057923af7e5eee05a989c) cleanup - [`18bdc7d`](https://github.com/aome510/spotify-player/commit/18bdc7d0c7da04ba3d6c3cf8a2ee1e990e551a0f) ignore `clippy` warning for `handle_command_for_track_table_window` ### 📊 Changes **12 files changed** (+257 additions, -146 deletions) <details> <summary>View changed files</summary> ➕ `.dir-locals.el` (+4 -0) 📝 `README.md` (+51 -47) 📝 `docs/config.md` (+1 -0) 📝 `examples/app.toml` (+1 -0) 📝 `spotify_player/src/command.rs` (+17 -0) 📝 `spotify_player/src/config/keymap.rs` (+32 -0) 📝 `spotify_player/src/config/mod.rs` (+4 -0) 📝 `spotify_player/src/event/mod.rs` (+0 -1) 📝 `spotify_player/src/event/page.rs` (+64 -14) 📝 `spotify_player/src/event/popup.rs` (+20 -2) 📝 `spotify_player/src/event/window.rs` (+24 -50) 📝 `spotify_player/src/ui/page.rs` (+39 -32) </details> ### 📄 Description Resolves #127 ## Changes - added more navigation commands + `PageSelectNextOrScrollDown` + `PageSelectPreviousOrScrollUp` + `SelectFirstOrScrollToTop` + `SelectLastOrScrollToBottom` - added `page_size_in_rows` config option to control the behavior of page navigation commands - added macro `handle_navigation_commands_for_page` to reduce the code duplication when implementing handlers for navigation commands --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>