[PR #75] [MERGED] Refactor playback rendering codes #1556

Closed
opened 2026-03-14 15:20:17 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/75
Author: @aome510
Created: 8/30/2022
Status: Merged
Merged: 8/30/2022
Merged by: @aome510

Base: masterHead: misc-improvments


📝 Commits (4)

  • 02e8296 add layout config options
  • 54fa033 refactor playback rendering codes
  • 6abeef5 update config.md: add new layout config options
  • 5ec5ed7 update render_playback_window function description

📊 Changes

5 files changed (+265 additions, -170 deletions)

View changed files

📝 doc/config.md (+3 -0)
📝 examples/app.toml (+3 -0)
📝 spotify_player/src/config/mod.rs (+16 -2)
📝 spotify_player/src/ui/mod.rs (+9 -168)
spotify_player/src/ui/playback.rs (+234 -0)

📄 Description

Changes


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/75 **Author:** [@aome510](https://github.com/aome510) **Created:** 8/30/2022 **Status:** ✅ Merged **Merged:** 8/30/2022 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `misc-improvments` --- ### 📝 Commits (4) - [`02e8296`](https://github.com/aome510/spotify-player/commit/02e82961dbe8b57e4ecab8866370a3ff66b1ac20) add layout config options - [`54fa033`](https://github.com/aome510/spotify-player/commit/54fa0338bd22de0a4db7969fdb79465cafcdab09) refactor playback rendering codes - [`6abeef5`](https://github.com/aome510/spotify-player/commit/6abeef5e233f4894643d406953e43f6cbf5bec6a) update `config.md`: add new layout config options - [`5ec5ed7`](https://github.com/aome510/spotify-player/commit/5ec5ed71b8fb4843e6c956571623a203b2ba68ec) update `render_playback_window` function description ### 📊 Changes **5 files changed** (+265 additions, -170 deletions) <details> <summary>View changed files</summary> 📝 `doc/config.md` (+3 -0) 📝 `examples/app.toml` (+3 -0) 📝 `spotify_player/src/config/mod.rs` (+16 -2) 📝 `spotify_player/src/ui/mod.rs` (+9 -168) ➕ `spotify_player/src/ui/playback.rs` (+234 -0) </details> ### 📄 Description ## Changes - added new `ui::playback` module - made the "rectangle split" code and "rendering" code more organized for different parts of the playback window - added layout config options. + Related: see https://github.com/aome510/spotify-player/issues/74#issuecomment-1225087875 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 15:20:17 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#1556
No description provided.