[PR #81] [MERGED] Handle device connection with retries #1552

New issue

Closed

opened 2026-03-14 15:20:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:20:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/81
Author: @aome510
Created: 9/16/2022
Status: ✅ Merged
Merged: 9/21/2022
Merged by: @aome510

Base: master ← Head: client-handler-misc-improvements

📝 Commits (10+)

ba5f788 move find-device-to-connect code from main to client::handlers
85c9303 add timeout policy for device connection on no playback
9144d42 re-implement find_available_device
e1ac78e misc changes
26c7344 update default_device documentation and default value
8c35fad Revert "update default_device documentation and default value"
26494d7 move available-device-connection logic to startup
8fef4f2 not blocking
c172d8e add ConnectDevice client request and use it to handle device connection on startup
65ad8ea also use ConnectDevice request after creating new streaming connection

📊 Changes

4 files changed (+138 additions, -110 deletions)

View changed files

📝 spotify_player/src/client/handlers.rs (+22 -13)
📝 spotify_player/src/client/mod.rs (+110 -77)
📝 spotify_player/src/event/mod.rs (+1 -0)
📝 spotify_player/src/main.rs (+5 -20)

📄 Description

Related #79

Breaking changes

add ConnectDevice client request to handle device connection with retries
move the playback update using multiple API requests code into a helper function Client::playback_update

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/81 **Author:** [@aome510](https://github.com/aome510) **Created:** 9/16/2022 **Status:** ✅ Merged **Merged:** 9/21/2022 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `client-handler-misc-improvements` --- ### 📝 Commits (10+) - [`ba5f788`](https://github.com/aome510/spotify-player/commit/ba5f7881d9f76a44ce4e1d2fcbba63937c5f41f8) move find-device-to-connect code from `main` to `client::handlers` - [`85c9303`](https://github.com/aome510/spotify-player/commit/85c93038e50c989bcda8d8f861468634b82b58e3) add timeout policy for device connection on no playback - [`9144d42`](https://github.com/aome510/spotify-player/commit/9144d4299afa66d9a0c3c38a38b8f009b7f660d1) re-implement `find_available_device` - [`e1ac78e`](https://github.com/aome510/spotify-player/commit/e1ac78e0f82bc55fe5c63754621417895d05984a) misc changes - [`26c7344`](https://github.com/aome510/spotify-player/commit/26c73443cb3859fee96aca5c68932b0597ab7480) update `default_device` documentation and default value - [`8c35fad`](https://github.com/aome510/spotify-player/commit/8c35fad8ab563c5b7641021968aa7c4587992ec2) Revert "update `default_device` documentation and default value" - [`26494d7`](https://github.com/aome510/spotify-player/commit/26494d736e0fbf3a0fe27b5e884b4acec9aa72ec) move available-device-connection logic to startup - [`8fef4f2`](https://github.com/aome510/spotify-player/commit/8fef4f24da4a66bbdae4356dbd75ba90ae709f47) not blocking - [`c172d8e`](https://github.com/aome510/spotify-player/commit/c172d8efa59ddfb4df5e0ac6358cb0bfe6114655) add `ConnectDevice` client request and use it to handle device connection on startup - [`65ad8ea`](https://github.com/aome510/spotify-player/commit/65ad8eaed1b2ad8076415554da9b855b45ff482e) also use `ConnectDevice` request after creating new streaming connection ### 📊 Changes **4 files changed** (+138 additions, -110 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/client/handlers.rs` (+22 -13) 📝 `spotify_player/src/client/mod.rs` (+110 -77) 📝 `spotify_player/src/event/mod.rs` (+1 -0) 📝 `spotify_player/src/main.rs` (+5 -20) </details> ### 📄 Description Related #79 ## Breaking changes - add `ConnectDevice` client request to handle device connection with retries - move the playback update using multiple API requests code into a helper function `Client::playback_update` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>