[PR #35] [MERGED] Improve application logging #1531

New issue

Closed

opened 2026-03-14 15:18:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:18:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/35
Author: @aome510
Created: 5/13/2022
Status: ✅ Merged
Merged: 5/14/2022
Merged by: @aome510

Base: master ← Head: 22-05-12/var-impr

📝 Commits (8)

0f5254b specify default log to crate-specific
fe9728d update log messages
7e224a3 make the "open config file" error more clear
9d3711c use error instead of warn for logging
8e9daf3 add more context
e381671 make log file based on time
78488e8 replace some error! by warn!
29174bd refactor error handling in ui module

📊 Changes

11 files changed (+71 additions, -60 deletions)

View changed files

📝 spotify_player/src/auth.rs (+2 -2)
📝 spotify_player/src/client/handlers.rs (+4 -5)
📝 spotify_player/src/client/mod.rs (+3 -8)
📝 spotify_player/src/client/spotify.rs (+1 -1)
📝 spotify_player/src/config/keymap.rs (+3 -3)
📝 spotify_player/src/config/mod.rs (+3 -3)
📝 spotify_player/src/config/theme.rs (+3 -3)
📝 spotify_player/src/event/mod.rs (+1 -1)
📝 spotify_player/src/main.rs (+28 -16)
📝 spotify_player/src/spirc.rs (+2 -2)
📝 spotify_player/src/ui/mod.rs (+21 -16)

📄 Description

Brief description of changes

only display crate's logs
improved log messages, added more context
improved client loggings, add elapsed timer
modified log file's name to include current time

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/35 **Author:** [@aome510](https://github.com/aome510) **Created:** 5/13/2022 **Status:** ✅ Merged **Merged:** 5/14/2022 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `22-05-12/var-impr` --- ### 📝 Commits (8) - [`0f5254b`](https://github.com/aome510/spotify-player/commit/0f5254b03b3ab23b0d4c7cb4d958c59b8c2f5216) specify default log to crate-specific - [`fe9728d`](https://github.com/aome510/spotify-player/commit/fe9728d7207b8b305473c632295ef8c4c017d87d) update log messages - [`7e224a3`](https://github.com/aome510/spotify-player/commit/7e224a3e18860398d92a42b7dd5ab30bab7ae467) make the "open config file" error more clear - [`9d3711c`](https://github.com/aome510/spotify-player/commit/9d3711c11a75e9d9ea53a9422ba50debd11414cf) use `error` instead of `warn` for logging - [`8e9daf3`](https://github.com/aome510/spotify-player/commit/8e9daf33031f067f4fa2cdfadbd8a82d247ba77f) add more context - [`e381671`](https://github.com/aome510/spotify-player/commit/e3816717512da267b3d7cbac661b976647d1bc4c) make log file based on time - [`78488e8`](https://github.com/aome510/spotify-player/commit/78488e805e0d15e6223378bf8ab7d418c7d6d6ee) replace some `error!` by `warn!` - [`29174bd`](https://github.com/aome510/spotify-player/commit/29174bd6fd9d535456aecbe491ac171350f338ee) refactor error handling in `ui` module ### 📊 Changes **11 files changed** (+71 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/auth.rs` (+2 -2) 📝 `spotify_player/src/client/handlers.rs` (+4 -5) 📝 `spotify_player/src/client/mod.rs` (+3 -8) 📝 `spotify_player/src/client/spotify.rs` (+1 -1) 📝 `spotify_player/src/config/keymap.rs` (+3 -3) 📝 `spotify_player/src/config/mod.rs` (+3 -3) 📝 `spotify_player/src/config/theme.rs` (+3 -3) 📝 `spotify_player/src/event/mod.rs` (+1 -1) 📝 `spotify_player/src/main.rs` (+28 -16) 📝 `spotify_player/src/spirc.rs` (+2 -2) 📝 `spotify_player/src/ui/mod.rs` (+21 -16) </details> ### 📄 Description ## Brief description of changes - only display crate's logs - improved log messages, added more context - improved client loggings, add elapsed timer - modified log file's name to include current time --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>