[PR #33] [MERGED] Change client/device reconnect logic #1527

New issue

Closed

opened 2026-03-14 15:18:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:18:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/33
Author: @aome510
Created: 3/6/2022
Status: ✅ Merged
Merged: 3/6/2022
Merged by: @aome510

Base: master ← Head: change-reconnect-logic

📝 Commits (4)

2a6ce0d require the reconnect flow to be explicit
ae797ec handle no playback on startup
767ee50 make spirc::new_connection non-async
a190a63 handle client reconnection when reconnecting an integrated client

📊 Changes

7 files changed (+140 additions, -91 deletions)

View changed files

📝 spotify_player/src/client/handlers.rs (+10 -12)
📝 spotify_player/src/client/mod.rs (+48 -41)
📝 spotify_player/src/event/mod.rs (+0 -1)
📝 spotify_player/src/event/popup.rs (+6 -1)
📝 spotify_player/src/main.rs (+55 -28)
📝 spotify_player/src/spirc.rs (+11 -8)
📝 spotify_player/src/ui/mod.rs (+10 -0)

📄 Description

Brief description of changes

removed PlayerRequest::Reconnect and made the reconnect flow explicit, e.g require users to manually reconnect instead of automatically making a reconnect request if no playback found.
updated the logic for handling no playback
updated the application initialization code on startup

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/33 **Author:** [@aome510](https://github.com/aome510) **Created:** 3/6/2022 **Status:** ✅ Merged **Merged:** 3/6/2022 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `change-reconnect-logic` --- ### 📝 Commits (4) - [`2a6ce0d`](https://github.com/aome510/spotify-player/commit/2a6ce0d57c8021b129bb89b3c5bc7a8718872cbd) require the reconnect flow to be explicit - [`ae797ec`](https://github.com/aome510/spotify-player/commit/ae797ec751161f6aa3dc672291121ce580e0d7bb) handle no playback on startup - [`767ee50`](https://github.com/aome510/spotify-player/commit/767ee502b23e2f9838a053b7f927ad7c377256da) make `spirc::new_connection` non-async - [`a190a63`](https://github.com/aome510/spotify-player/commit/a190a63844fdd9eaf3f6c9145cd31b08682c9f22) handle client reconnection when reconnecting an integrated client ### 📊 Changes **7 files changed** (+140 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/client/handlers.rs` (+10 -12) 📝 `spotify_player/src/client/mod.rs` (+48 -41) 📝 `spotify_player/src/event/mod.rs` (+0 -1) 📝 `spotify_player/src/event/popup.rs` (+6 -1) 📝 `spotify_player/src/main.rs` (+55 -28) 📝 `spotify_player/src/spirc.rs` (+11 -8) 📝 `spotify_player/src/ui/mod.rs` (+10 -0) </details> ### 📄 Description ## Brief description of changes - removed `PlayerRequest::Reconnect` and made the reconnect flow explicit, e.g require users to manually reconnect instead of automatically making a reconnect request if no playback found. - updated the logic for handling no playback - updated the application initialization code on startup --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>