[PR #25] [MERGED] Rewrite the context page state's structure #1526

New issue

Closed

opened 2026-03-14 15:18:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:18:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/25
Author: @aome510
Created: 10/31/2021
Status: ✅ Merged
Merged: 10/31/2021
Merged by: @aome510

Base: master ← Head: rewrite-context-page-structure

📝 Commits (7)

63d6bfe use PageState::Context in the event module
39db0df update the state structures
10ba105 remove utils::update_context
e4d843f remove unused send in command handler functions
59af2f2 handle rendering the context page and update its window state on changes
ad3f546 cleanup
0e391db empty the PageState::Context's context_id when handling PreviousPage

📊 Changes

8 files changed (+180 additions, -250 deletions)

View changed files

📝 spotify_player/src/event/mod.rs (+9 -4)
📝 spotify_player/src/event/popup.rs (+15 -20)
📝 spotify_player/src/event/window.rs (+54 -53)
📝 spotify_player/src/state/player.rs (+20 -16)
📝 spotify_player/src/state/ui.rs (+17 -2)
📝 spotify_player/src/ui/mod.rs (+53 -88)
📝 spotify_player/src/ui/window.rs (+12 -11)
📝 spotify_player/src/utils.rs (+0 -56)

📄 Description

Brief description of changes

use PageState::Context as a combination of PageState::Browsing, PageState::CurrentPlaying
handle window state update logic and context data request logic in the ui::handle_page_state_change function

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/25 **Author:** [@aome510](https://github.com/aome510) **Created:** 10/31/2021 **Status:** ✅ Merged **Merged:** 10/31/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `rewrite-context-page-structure` --- ### 📝 Commits (7) - [`63d6bfe`](https://github.com/aome510/spotify-player/commit/63d6bfe32efca91356eda105a2a2def73f6b1d8e) use `PageState::Context` in the `event` module - [`39db0df`](https://github.com/aome510/spotify-player/commit/39db0df06d29d56eecbeb800bbab8f27ba687fda) update the state structures - [`10ba105`](https://github.com/aome510/spotify-player/commit/10ba1058fe5df41d7482f6b898dc0e20e3389aaa) remove `utils::update_context` - [`e4d843f`](https://github.com/aome510/spotify-player/commit/e4d843fc8f1a84238c2883e972f297716e654e7f) remove unused `send` in command handler functions - [`59af2f2`](https://github.com/aome510/spotify-player/commit/59af2f2fc7e702f1067b1c7d7e94585c1d746705) handle rendering the context page and update its window state on changes - [`ad3f546`](https://github.com/aome510/spotify-player/commit/ad3f54682f28f1e59edcfebecb485e0968e8cb32) cleanup - [`0e391db`](https://github.com/aome510/spotify-player/commit/0e391db35d553c55b50ce62d28e1fc15014ed348) empty the `PageState::Context`'s `context_id` when handling `PreviousPage` ### 📊 Changes **8 files changed** (+180 additions, -250 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/event/mod.rs` (+9 -4) 📝 `spotify_player/src/event/popup.rs` (+15 -20) 📝 `spotify_player/src/event/window.rs` (+54 -53) 📝 `spotify_player/src/state/player.rs` (+20 -16) 📝 `spotify_player/src/state/ui.rs` (+17 -2) 📝 `spotify_player/src/ui/mod.rs` (+53 -88) 📝 `spotify_player/src/ui/window.rs` (+12 -11) 📝 `spotify_player/src/utils.rs` (+0 -56) </details> ### 📄 Description ## Brief description of changes - use `PageState::Context` as a combination of `PageState::Browsing`, `PageState::CurrentPlaying` - handle window state update logic and context data request logic in the `ui::handle_page_state_change` function --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>