[PR #21] [MERGED] Change the application's behavior on startup #1521

New issue

Closed

opened 2026-03-14 15:18:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:18:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/21
Author: @aome510
Created: 10/27/2021
Status: ✅ Merged
Merged: 10/27/2021
Merged by: @aome510

Base: master ← Head: change-app-behavior-on-startup

📝 Commits (8)

edc6c8a upgrade dependencies
d02dbd3 reduce the number of requests on startup
bad54bf not using pretty printing for loggings
bf6b87b add PlayerRequest::Reconnect
440602e not storing the a list of playlists inside PopupState::UserPlaylistList
a073fb1 update README
8c2b827 fix formatting error
1005c2f cleanup

📊 Changes

19 files changed (+165 additions, -152 deletions)

View changed files

📝 Cargo.lock (+22 -22)
📝 README.md (+7 -11)
📝 spotify_player/Cargo.toml (+5 -5)
📝 spotify_player/src/client/handlers.rs (+23 -45)
📝 spotify_player/src/client/mod.rs (+41 -6)
📝 spotify_player/src/config/keymap.rs (+1 -1)
📝 spotify_player/src/config/mod.rs (+1 -1)
📝 spotify_player/src/config/theme.rs (+1 -1)
📝 spotify_player/src/connect.rs (+1 -4)
📝 spotify_player/src/event/mod.rs (+3 -3)
📝 spotify_player/src/event/popup.rs (+25 -29)
📝 spotify_player/src/main.rs (+3 -14)
📝 spotify_player/src/state/data.rs (+14 -0)
📝 spotify_player/src/state/mod.rs (+3 -3)
📝 spotify_player/src/state/ui.rs (+1 -1)
📝 spotify_player/src/token.rs (+1 -1)
📝 spotify_player/src/ui/mod.rs (+1 -1)
📝 spotify_player/src/ui/popup.rs (+11 -3)
📝 spotify_player/src/utils.rs (+1 -1)

📄 Description

Brief description of changes

change how the application connects to a device on startup
- now, it'll connect to first available device and if not able to find one, connect to the integrated device
- this approach doesn't require to specify one's own client_id to use the integrated client
reduce the number of initial requests on startup to get the application's data
use non-pretty-printing for logging
upgrade dependencies (librespot-* to v0.3.1, crossterm to 0.22.1, reqwest to 0.11.6)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/21 **Author:** [@aome510](https://github.com/aome510) **Created:** 10/27/2021 **Status:** ✅ Merged **Merged:** 10/27/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `change-app-behavior-on-startup` --- ### 📝 Commits (8) - [`edc6c8a`](https://github.com/aome510/spotify-player/commit/edc6c8ada635edda5e45cc2f8d7f903f003f42f4) upgrade dependencies - [`d02dbd3`](https://github.com/aome510/spotify-player/commit/d02dbd3b26410f3afc0ef89bda5fcce44dd89d7d) reduce the number of requests on startup - [`bad54bf`](https://github.com/aome510/spotify-player/commit/bad54bff2b6ee16fb442ddf70fec0c4686f83c19) not using pretty printing for loggings - [`bf6b87b`](https://github.com/aome510/spotify-player/commit/bf6b87bc4a28c00f1aee327c3297279a2f99ae01) add `PlayerRequest::Reconnect` - [`440602e`](https://github.com/aome510/spotify-player/commit/440602e944e91c8bf5ec631fb55fe688d9b5bb25) not storing the a list of playlists inside `PopupState::UserPlaylistList` - [`a073fb1`](https://github.com/aome510/spotify-player/commit/a073fb1b3245cf37048b2de529aebeb94febd699) update `README` - [`8c2b827`](https://github.com/aome510/spotify-player/commit/8c2b827567cb9dad66b9109192413cbcc6612ee8) fix formatting error - [`1005c2f`](https://github.com/aome510/spotify-player/commit/1005c2f58ffd9839d9d1bed967a8db8df9c5c00f) cleanup ### 📊 Changes **19 files changed** (+165 additions, -152 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+22 -22) 📝 `README.md` (+7 -11) 📝 `spotify_player/Cargo.toml` (+5 -5) 📝 `spotify_player/src/client/handlers.rs` (+23 -45) 📝 `spotify_player/src/client/mod.rs` (+41 -6) 📝 `spotify_player/src/config/keymap.rs` (+1 -1) 📝 `spotify_player/src/config/mod.rs` (+1 -1) 📝 `spotify_player/src/config/theme.rs` (+1 -1) 📝 `spotify_player/src/connect.rs` (+1 -4) 📝 `spotify_player/src/event/mod.rs` (+3 -3) 📝 `spotify_player/src/event/popup.rs` (+25 -29) 📝 `spotify_player/src/main.rs` (+3 -14) 📝 `spotify_player/src/state/data.rs` (+14 -0) 📝 `spotify_player/src/state/mod.rs` (+3 -3) 📝 `spotify_player/src/state/ui.rs` (+1 -1) 📝 `spotify_player/src/token.rs` (+1 -1) 📝 `spotify_player/src/ui/mod.rs` (+1 -1) 📝 `spotify_player/src/ui/popup.rs` (+11 -3) 📝 `spotify_player/src/utils.rs` (+1 -1) </details> ### 📄 Description ## Brief description of changes - change how the application connects to a device on startup + now, it'll connect to first available device and if not able to find one, connect to the integrated device + this approach doesn't require to specify one's own `client_id` to use the integrated client - reduce the number of initial requests on startup to get the application's data - use non-pretty-printing for logging - upgrade dependencies (`librespot-*` to `v0.3.1`, `crossterm` to `0.22.1`, `reqwest` to `0.11.6`) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>