[PR #16] [MERGED] Improve client performance with parellelism #1512

New issue

Closed

opened 2026-03-14 15:18:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:18:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/16
Author: @aome510
Created: 10/19/2021
Status: ✅ Merged
Merged: 10/19/2021
Merged by: @aome510

Base: master ← Head: improve-client-performance

📝 Commits (5)

27dccec improve client::search performance with parellelism
15c625d handle each client request in a separated tokio task
349b247 add state::SimplifiedPlayback
a3bf455 change the context update condition inside client::watch_player_events
fd0ab70 undo unnecessary change

📊 Changes

3 files changed (+76 additions, -58 deletions)

View changed files

📝 spotify_player/src/client/handlers.rs (+9 -4)
📝 spotify_player/src/client/mod.rs (+48 -54)
📝 spotify_player/src/state/player.rs (+19 -0)

📄 Description

Brief description of changes

spawn a tokio::Task to search for each item type in client::search
spawn a tokio::Task to handle each event::ClientRequest
fix bug that doesn't update context if there is already a cache

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/16 **Author:** [@aome510](https://github.com/aome510) **Created:** 10/19/2021 **Status:** ✅ Merged **Merged:** 10/19/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `improve-client-performance` --- ### 📝 Commits (5) - [`27dccec`](https://github.com/aome510/spotify-player/commit/27dcceccc4fbe9a07355887d1e7cb4426909a89c) improve `client::search` performance with parellelism - [`15c625d`](https://github.com/aome510/spotify-player/commit/15c625d9347caad0bf6d352f15d4991b4c04dcd0) handle each client request in a separated tokio task - [`349b247`](https://github.com/aome510/spotify-player/commit/349b2479863a544e07888bcc77c3574a16de7193) add `state::SimplifiedPlayback` - [`a3bf455`](https://github.com/aome510/spotify-player/commit/a3bf455d837d4ae12d7b50bab598b1cfa77f236c) change the context update condition inside `client::watch_player_events` - [`fd0ab70`](https://github.com/aome510/spotify-player/commit/fd0ab7085862a47aafc2d383e6b8796d0b75647e) undo unnecessary change ### 📊 Changes **3 files changed** (+76 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/client/handlers.rs` (+9 -4) 📝 `spotify_player/src/client/mod.rs` (+48 -54) 📝 `spotify_player/src/state/player.rs` (+19 -0) </details> ### 📄 Description ## Brief description of changes - spawn a `tokio::Task` to search for each item type in `client::search` - spawn a `tokio::Task` to handle each `event::ClientRequest` - fix bug that doesn't update context if there is already a cache --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>