[PR #9] [MERGED] Use non-blocking implementation for client request handler #1509

New issue

Closed

opened 2026-03-14 15:17:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:17:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/9
Author: @aome510
Created: 9/24/2021
Status: ✅ Merged
Merged: 9/24/2021
Merged by: @aome510

Base: master ← Head: exp-improve-client-perf

📝 Commits (6)

dbf8274 prevent stopping the player event watchers when encountering errors
464f8ba rename Event to ClientRequest, PlayerEvent to PlayerRequest
052f71a clean up
b018278 try to handle the client request without blocking the handler thread
0ccf54a handle TransferPlayback request differently from other player requests
c4686f7 clean up, update documentation and variable namings

📊 Changes

4 files changed (+250 additions, -231 deletions)

View changed files

📝 spotify_player/src/client.rs (+194 -157)
📝 spotify_player/src/event.rs (+42 -44)
📝 spotify_player/src/main.rs (+13 -5)
📝 spotify_player/src/utils.rs (+1 -25)

📄 Description

Brief description of new changes

Rename Event and PlayerEvent to ClientRequest and PlayerRequest
Make the client request handler non-blocking by cloning the client and handle the request separately

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/9 **Author:** [@aome510](https://github.com/aome510) **Created:** 9/24/2021 **Status:** ✅ Merged **Merged:** 9/24/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `exp-improve-client-perf` --- ### 📝 Commits (6) - [`dbf8274`](https://github.com/aome510/spotify-player/commit/dbf82747270e1ee642011af9fe366835e1caa922) prevent stopping the player event watchers when encountering errors - [`464f8ba`](https://github.com/aome510/spotify-player/commit/464f8baf20e6977e661bc8e826175339b34e75ad) rename `Event` to `ClientRequest`, `PlayerEvent` to `PlayerRequest` - [`052f71a`](https://github.com/aome510/spotify-player/commit/052f71af853c0fc192335a1653106ca68d1adfd2) clean up - [`b018278`](https://github.com/aome510/spotify-player/commit/b018278a84b8e51d27c56ecf40d7a656c7909d44) try to handle the client request without blocking the handler thread - [`0ccf54a`](https://github.com/aome510/spotify-player/commit/0ccf54af39e26730bcb8ac309c0a973604ae546b) handle `TransferPlayback` request differently from other player requests - [`c4686f7`](https://github.com/aome510/spotify-player/commit/c4686f7139c1a7d30c9fb25996f07d3e07ed2d8d) clean up, update documentation and variable namings ### 📊 Changes **4 files changed** (+250 additions, -231 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/client.rs` (+194 -157) 📝 `spotify_player/src/event.rs` (+42 -44) 📝 `spotify_player/src/main.rs` (+13 -5) 📝 `spotify_player/src/utils.rs` (+1 -25) </details> ### 📄 Description # Brief description of new changes - Rename `Event` and `PlayerEvent` to `ClientRequest` and `PlayerRequest` - Make the client request handler non-blocking by cloning the client and handle the request separately --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>