[PR #3] [MERGED] Librespot integration Part II: add support for librespot player #1506

New issue

Closed

opened 2026-03-14 15:17:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:17:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/3
Author: @aome510
Created: 8/22/2021
Status: ✅ Merged
Merged: 8/24/2021
Merged by: @aome510

Base: master ← Head: add-librespot-playback-support

📝 Commits (10+)

63198fc handle player events separately from normal client events.
79920b7 add remote CLI argument for determining player type during initialization
ebf94c5 be able to play a track using librespot playback
9167753 store the application's state inside the player
6d574dc Merge remote-tracking branch 'origin/master' into add-librespot-playback-support
1a4e600 small refactor
dcaf649 temporarily disable audit-on-push
45c0bd0 delete player.rs
0175c5e spotify connect with librespot kinda works
7b3ea13 cleanup connection logic

📊 Changes

16 files changed (+935 additions, -173 deletions)

View changed files

📝 .github/workflows/audit-on-push.yml (+15 -14)
📝 Cargo.lock (+627 -5)
📝 Cargo.toml (+0 -1)
📝 README.md (+2 -0)
📝 doc/config.md (+13 -0)
📝 spotify_player/Cargo.toml (+8 -0)
📝 spotify_player/src/client.rs (+100 -121)
📝 spotify_player/src/command.rs (+4 -0)
📝 spotify_player/src/config/keymap.rs (+8 -0)
📝 spotify_player/src/config/mod.rs (+25 -1)
➕ spotify_player/src/connect.rs (+52 -0)
📝 spotify_player/src/event.rs (+51 -26)
📝 spotify_player/src/main.rs (+18 -3)
📝 spotify_player/src/state/player.rs (+3 -0)
📝 spotify_player/src/ui/context.rs (+3 -1)
📝 spotify_player/src/ui/mod.rs (+6 -1)

📄 Description

Brief description of changes

integrate librespot as a spotify device and use it as the default device when running the application
add a DeviceConfig for configure new librespot device
handle PlayerEvent separately from other client events
add librespot-connect and librespot's supported audio backends
add VolumeUp and VolumeDown commands

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/3 **Author:** [@aome510](https://github.com/aome510) **Created:** 8/22/2021 **Status:** ✅ Merged **Merged:** 8/24/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `add-librespot-playback-support` --- ### 📝 Commits (10+) - [`63198fc`](https://github.com/aome510/spotify-player/commit/63198fc13e951c78f84d7239f5bf391e016d970d) handle player events separately from normal client events. - [`79920b7`](https://github.com/aome510/spotify-player/commit/79920b7def96b7f963a5e5af4fabd54f5f23678b) add `remote` CLI argument for determining player type during initialization - [`ebf94c5`](https://github.com/aome510/spotify-player/commit/ebf94c544162f8f618f0e10f53c145e7c7bd4508) be able to play a track using librespot playback - [`9167753`](https://github.com/aome510/spotify-player/commit/9167753197de246e3f122fc1be1fb78b220d5221) store the application's state inside the player - [`6d574dc`](https://github.com/aome510/spotify-player/commit/6d574dc099af92f4629328f2bbd786f188bae226) Merge remote-tracking branch 'origin/master' into add-librespot-playback-support - [`1a4e600`](https://github.com/aome510/spotify-player/commit/1a4e600d841f9a189b72ece2fa67f1fa230c8256) small refactor - [`dcaf649`](https://github.com/aome510/spotify-player/commit/dcaf6492cb4bf7ff13135c6e5a27fbf399ca4a88) temporarily disable audit-on-push - [`45c0bd0`](https://github.com/aome510/spotify-player/commit/45c0bd0013c34874c9c164b342a601453f6fc89b) delete `player.rs` - [`0175c5e`](https://github.com/aome510/spotify-player/commit/0175c5e195e9d61c10bfea92e25eb2578d69861a) spotify connect with librespot kinda works - [`7b3ea13`](https://github.com/aome510/spotify-player/commit/7b3ea1393ed70ec1b1b2a1122313d016b7ee63e6) cleanup connection logic ### 📊 Changes **16 files changed** (+935 additions, -173 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/audit-on-push.yml` (+15 -14) 📝 `Cargo.lock` (+627 -5) 📝 `Cargo.toml` (+0 -1) 📝 `README.md` (+2 -0) 📝 `doc/config.md` (+13 -0) 📝 `spotify_player/Cargo.toml` (+8 -0) 📝 `spotify_player/src/client.rs` (+100 -121) 📝 `spotify_player/src/command.rs` (+4 -0) 📝 `spotify_player/src/config/keymap.rs` (+8 -0) 📝 `spotify_player/src/config/mod.rs` (+25 -1) ➕ `spotify_player/src/connect.rs` (+52 -0) 📝 `spotify_player/src/event.rs` (+51 -26) 📝 `spotify_player/src/main.rs` (+18 -3) 📝 `spotify_player/src/state/player.rs` (+3 -0) 📝 `spotify_player/src/ui/context.rs` (+3 -1) 📝 `spotify_player/src/ui/mod.rs` (+6 -1) </details> ### 📄 Description **Brief description of changes** - integrate `librespot` as a spotify device and use it as the default device when running the application - add a `DeviceConfig` for configure new librespot device - handle `PlayerEvent` separately from other client events - add `librespot-connect` and librespot's supported audio backends - add `VolumeUp` and `VolumeDown` commands --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>