mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[GH-ISSUE #59] Allow configuring the ap_port #13
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#13
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bartlibert on GitHub (Jun 30, 2022).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/59
Originally assigned to: @aome510 on GitHub.
The proxy at my work is really strict on outgoing ports. I see from the librespot logs that most of the time, for authentication, the ap tries to connect to a server using port 4070 (e.g. ap-gew1.spotify.com:4070). This times out in the end, because the port is blocked.
I did a quick hack here:
github.com/aome510/spotify-player@52908a4d13/spotify_player/src/auth.rs (L39)and here:
github.com/aome510/spotify-player@52908a4d13/spotify_player/src/auth.rs (L82)To use a SessionConfig with ap_port Some(443) instead of the defaults, and now the app works.
Would it be possible to implement a possibility to configure this port in the config file?
Thanks!
@aome510 commented on GitHub (Jun 30, 2022):
Thanks for taking a look into this.
That should be easy. Will create a patch by EOD.
@aome510 commented on GitHub (Jul 1, 2022):
@bartlibert created the patch here. Can you check out the branch and run the app locally to see if the patch works.
ap_portis configurable by adding aapp_port={port}line in yourapp.toml.@bartlibert commented on GitHub (Jul 1, 2022):
I tested the port setting with this branch, and it works fine, thanks! I have no proxy available to test, so that part is untested, but I guess it's very similar, so it should work as well.