starred/spotify-player

Fork 0

mirror of https://github.com/aome510/spotify-player.git synced 2026-04-26 09:25:49 +03:00

[GH-ISSUE #523] Remap / rebind keymap to action #1235

New issue

Closed

opened 2026-03-14 14:02:42 +03:00 by kerem · 7 comments

kerem commented

2026-03-14 14:02:42 +03:00

Owner

Originally created by @arouene on GitHub (Jul 29, 2024).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/523

Describe the bug
It does not seem possible to remap a kemap (like C-p which is bind to "SelectPreviousOrScrollUp") to an action (like "AddToPlaylist").

To Reproduce
I have this keymap.toml

[[keymaps]]
command = "SelectPreviousOrScrollUp"
key_sequence = "k"

[[actions]]
action = "AddToPlaylist"
key_sequence = "C-p"

Expected behaviour
SelectPreviousOrScrollUp is k
AddToPlaylist is C-p

Environment

OS: Linux Fedora 40
Application version: 0.19.1

Originally created by @arouene on GitHub (Jul 29, 2024). Original GitHub issue: https://github.com/aome510/spotify-player/issues/523 **Describe the bug** It does not seem possible to remap a kemap (like C-p which is bind to "SelectPreviousOrScrollUp") to an action (like "AddToPlaylist"). **To Reproduce** I have this **keymap.toml** ``` [[keymaps]] command = "SelectPreviousOrScrollUp" key_sequence = "k" [[actions]] action = "AddToPlaylist" key_sequence = "C-p" ``` **Expected behaviour** SelectPreviousOrScrollUp is k AddToPlaylist is C-p **Environment** - OS: Linux Fedora 40 - Application version: 0.19.1

kerem

2026-03-14 14:02:42 +03:00

closed this issue
added the
bug

good first issue
labels

kerem commented

2026-03-14 14:02:57 +03:00

Author

Owner

@arouene commented on GitHub (Jul 29, 2024):

Besides, why do we make a difference between a keymap and an action?

@arouene commented on GitHub (Jul 29, 2024): Besides, why do we make a difference between a keymap and an action?

kerem commented

2026-03-14 14:03:02 +03:00

Author

Owner

@aome510 commented on GitHub (Jul 29, 2024):

Besides, why do we make a difference between a keymap and an action?

I think you mean command and action. The difference is that action performs on a specific item (input) while command is supposed to be a general operation w/o input.

@aome510 commented on GitHub (Jul 29, 2024): > Besides, why do we make a difference between a keymap and an action? I think you mean `command` and `action`. The difference is that `action` performs on a specific item (input) while `command` is supposed to be a general operation w/o input.

kerem commented

2026-03-14 14:03:08 +03:00

Author

Owner

@arouene commented on GitHub (Jul 29, 2024):

Oh ok, I see, thank you !

@arouene commented on GitHub (Jul 29, 2024): Oh ok, I see, thank you !

kerem commented

2026-03-14 14:03:13 +03:00

Author

Owner

@aome510 commented on GitHub (Jul 29, 2024):

You can bind C-p to an action by binding C-p to command = "None" to allow re-use the key.

@aome510 commented on GitHub (Jul 29, 2024): You can bind `C-p` to an action by binding `C-p` to `command = "None"` to allow re-use the key.

kerem commented

2026-03-14 14:03:18 +03:00

Author

Owner

@arouene commented on GitHub (Jul 29, 2024):

I did try that, but then C-p is just not bind to anything

[[keymaps]]
command = "SelectPreviousOrScrollUp"
key_sequence = "k"

[[keymaps]]
command = "None"
key_sequence = "C-p"

[[actions]]
action = "AddToPlaylist"
key_sequence = "C-p"

@arouene commented on GitHub (Jul 29, 2024): I did try that, but then C-p is just not bind to anything ``` [[keymaps]] command = "SelectPreviousOrScrollUp" key_sequence = "k" [[keymaps]] command = "None" key_sequence = "C-p" [[actions]] action = "AddToPlaylist" key_sequence = "C-p" ```

kerem commented

2026-03-14 14:03:23 +03:00

Author

Owner

@aome510 commented on GitHub (Jul 29, 2024):

I see, then it's bug that doesn't allow to re-use None command. It should be easy to update github.com/aome510/spotify-player@58a5ace777/spotify_player/src/config/keymap.rs (L416) to ignore None command.

@aome510 commented on GitHub (Jul 29, 2024): I see, then it's bug that doesn't allow to re-use `None` command. It should be easy to update https://github.com/aome510/spotify-player/blob/58a5ace777293ed04fb0da44075a27d777822501/spotify_player/src/config/keymap.rs#L416 to ignore `None` command.

kerem commented

2026-03-14 14:03:28 +03:00

Author

Owner

@arouene commented on GitHub (Jul 29, 2024):

Fixed in PR

@arouene commented on GitHub (Jul 29, 2024): Fixed in PR