mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[GH-ISSUE #457] Podcast Support #1194
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#1194
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @fwastring on GitHub (May 28, 2024).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/457
Is your feature already implemented in the latest
master?No
Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
I would like to have podcast support available in the app. When I search for podcasts, I don't get any of the results I'm expecting. Possibly another pane with podcast results only. I haven't dabbled with Spotifys Podcast API so I'm not sure how the implementation would be done.
@vannotz commented on GitHub (May 30, 2024):
It seems to kinda already support it? If I'm playing a podcast on my phone, then open spotify-player on the desktop and just hit "space" without actually choosing a song, the podcast I was listing to will start playing but nothing will show on playback. So I guess it technically already has that functionality, just no search.
@fwastring commented on GitHub (May 30, 2024):
I've seen that too! I was referring to functionality where you could search for, browse and play podcasts. But playback if started from another device seems supported!
@aome510 commented on GitHub (May 31, 2024):
Related:
Podcast is not my priority since I never use it personally. PRs are highly welcome though!
@fwastring commented on GitHub (Jun 4, 2024):
Do you have any tips for how I would implement it? Do you think it would be a lot of work? @aome510
@thenbe commented on GitHub (Jun 8, 2024):
@fwastring From a UX perspective, I feel like
podcastsandpodcast_episodesshould be top-level entities. For instance if a user searches forfoo:They should see results from these types:
Actions (context menu)
A
podcastcan have similar actions* to anartist. Some modifications would be required:A
podcast_episodecan have similar actions* to atrack. Some modifications would be required:* By actions, I'm referring to the menu you can invoke by pressing
g awhen hovering over a list item (e.g. in the search results).Pages
The
podcastdetail page can be simple. It can contain a single list ofpodcast_episodes(similar in layout to thealbumdetail page).I don't see the need for
podcast_episodedetail page. Similar to how atrackdoes not currently have it's own page.@aome510 commented on GitHub (Jun 8, 2024):
Thanks @thenbe for the suggestions!
Sorry I missed the message. It should be relatively straightforward to add support for podcast as you can follow the already established patterns in the codebase. This is not a "good first issue" in a way that the implementation will need to touch many places in the codebase, which might require a certain level of familiarity.