mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[GH-ISSUE #454] Title overflows when too long #1189
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#1189
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sewnie on GitHub (May 25, 2024).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/454
Describe the bug
When listening to a song with a long name, the name overflows to the the album cover & metadata
To Reproduce
Listen to a song with a long title, such as 'tálcunnana dëhajma tun dejl bënatsë abcul’han dlhenic ëlh inagat, jahadlhë adrhasha indauzglën nu dlhevusao ibajngra nava líeshtamhan ëf novejhan conetc danëctc qin, ëf tu dlhicadëtrhënna bë ablhundrhaba judjenan alhëtangrasë shidandlhamësë inqom' by Trhä
Expected behaviour
The song title doesn't overflow everywhere.
Screenshots

If listened to another song,


The previous album cover appears (no song played previously):
Default app.toml:
@cwillsey06 commented on GitHub (May 25, 2024):
😭
@aome510 commented on GitHub (Aug 4, 2024):
can you fix this issue by increasing
playback_window_width?@sewnie commented on GitHub (Aug 4, 2024):
playback_window_widthShouldn't be an option, and it isn't. There is nothing next to the playback window.@aome510 commented on GitHub (Aug 4, 2024):
playback_window_widthactually is a quite confusing naming.widthhere refers to the vertical spaces and I thought if you increase the vertical spaces then overflowing is not an issue anymore?@sewnie commented on GitHub (Aug 4, 2024):
The option you're talking about was removed in
2030b4ee94.@sewnie commented on GitHub (Aug 4, 2024):
Here's something interesting:
@aome510 commented on GitHub (Aug 4, 2024):
no it's renamed to
layout.playback_window_heightright, that's an issue, so we also need to truncate the title when saving file
@sewnie commented on GitHub (Aug 4, 2024):
Why not save the file with it's spotify ID?
@sewnie commented on GitHub (Aug 4, 2024):
@aome510 commented on GitHub (Aug 4, 2024):
because I think it's useful to be able to search the cover images using album's name or artist's name
@aome510 commented on GitHub (Aug 4, 2024):
I see, is it because you use spaces in
playback_formatto add paddings? I think we should disable wrapping when rendering the playback data, then we can also have truncating for free.