mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 17:35:50 +03:00
[GH-ISSUE #425] Search from CLI #1166
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#1166
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @davepgreene on GitHub (Apr 22, 2024).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/425
Is your feature already implemented in the latest
master?No
Is your feature request related to a problem? Please describe.
Right now the current method for getting search-like information from Spotify via the CLI is to use
spotify_player get item <TYPE> --name. Unfortunately this only returns a single result rather than the list of results that the TUI returns when searching.Describe the solution you'd like
A new CLI command called
searchwhich allows users to do the same kind of search that the TUI does.Describe alternatives you've considered
N/A
Additional context
From poking through the codebase (I'm not super familiar with Rust so I'm sure I've missed something here) it looks like the CLI does item retrieval calls out directly to the
artist,track,playlist, andtrackmethods in rspotify. Would it be too much work to wire up thesearchmethod as well?@aome510 commented on GitHub (Apr 24, 2024):
Shouldn't be too difficult to define a
searchCLI command as client does providesearch(github.com/aome510/spotify-player@2b8f2530cb/spotify_player/src/client/mod.rs (L832)) andsearch_specific_type(github.com/aome510/spotify-player@2b8f2530cb/spotify_player/src/client/mod.rs (L880))@kadinsayani commented on GitHub (Apr 25, 2024):
Hi, I'd like to give this a try if that's okay with you? Thanks!
@aome510 commented on GitHub (Apr 25, 2024):
yes, please do. Lmk when you have a PR up