mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 17:35:50 +03:00
[GH-ISSUE #399] Glitchy image album cover image behavior in kitty Mac OS #1150
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#1150
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @fuzetsu on GitHub (Mar 23, 2024).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/399
Describe the bug
Album cover image rendering is glitchy in kitty (the terminal app) running on Mac OS:
?Of note is that this works fine in iterm2 (and maybe most terminal emulators?)
I suppose this might be a bug in kitty? difference in how images are cleaned up between screens?
To Reproduce
Open any song with album art and notice image is stretched. Press
?to open help screen andExpected behaviour
Image should appear and disappear as expected and should be scaled appropriately.
Screenshots
Environment
@aome510 commented on GitHub (Mar 23, 2024):
@fuzetsu thanks for reporting. Can confirm this issue also happens to me with
imageoniterm2. I didn't notice this issue as I don't really use?for help page nowadays 😅 .@aome510 commented on GitHub (Mar 23, 2024):
Should be fixed with #400. Can you try the latest
master?@fuzetsu commented on GitHub (Mar 24, 2024):
Thanks! Tried out latest
masterbut now I'm seeing no image at all (in all terminals).I just cloned the repo and used
cargo run.@aome510 commented on GitHub (Mar 24, 2024):
should be
cargo run --features image.@fuzetsu commented on GitHub (Mar 24, 2024):
Just saw that 🤦
Thanks! Trying again.
@fuzetsu commented on GitHub (Mar 24, 2024):
Seems to be fixed now! Also fixed some weirdness with the top line of the help I noticed before.
Images are still a bit squeezed in kitty though, I'm now thinking it might be a config issue on my side though because of line height 🤔
@fuzetsu commented on GitHub (Mar 24, 2024):
Hmm, yeah looks fine with other fonts. My problem then I guess 😆
@ghost commented on GitHub (Apr 4, 2024):
still occuring on 0.17.2 for me
@aome510 commented on GitHub (Apr 4, 2024):
Is this behaviour consistent? What terminal are you using?
@ghost commented on GitHub (Apr 4, 2024):
This behavior is consistent on Kitty terminal on NixOS. Using latest kitty and spotify-player on nixpkgs unstable.
@icep0ps commented on GitHub (Jun 5, 2024):
I was having the same problem, I kind of fixed this by adding the following to the app.toml
@diegoulloao commented on GitHub (Jun 10, 2024):
same issue, it depends of the line height you're using, you can play with the
cover_img_lengthvalue till the image is squared