mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[GH-ISSUE #326] Blank space drawn on top left blocking content if playback_window_position is Bottom #1110
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#1110
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ed9w2in6 on GitHub (Jan 2, 2024).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/326
Symptom

Weird album art artefact drawn on terminal when
playback_window_positionis set toBottomas shown in this screenshot:Blank space drawn on top left that matches the dimensions of the album art.
I guess some logic that allocates space fell through some branch checks.
You won't notice this if
playback_window_positionis set to Top.Expected behavior
There should NOT be blank space on the top left.
To Reproduce
spotify_playerwith theimagefeaturespotify_playerto generate defaultapp.tomlplayback_window_positiontoBottomspotify_playerLog and backtrace
No obvious trace from logs, will provide if needed.
Environment
spotify_player 0.16.2spotify_playerusingcargowith these options:fastfetchoutput (truncated):Additional context
Issue appeared since version
0.16.2.Issue rating
playback_window_positiontoTopto avoid the issue for now@aome510 commented on GitHub (Jan 2, 2024):
@ed9w2in6 should be fixed by #328. Can you check out and run the branch locally to see if the fix works?
@sewnie commented on GitHub (Jan 3, 2024):
Solves my issue!
@ed9w2in6 commented on GitHub (Jan 8, 2024):
@aome510 wow I did not expect you to fix this that quickly, thanks!
I can confirm that it solves the issue for me as well and again thank you for your time on fixing this.